diff options
author | gavinp@chromium.org <gavinp@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-04 21:58:25 +0000 |
---|---|---|
committer | gavinp@chromium.org <gavinp@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-04 21:58:25 +0000 |
commit | 510f705cfeaa21a3c3e768e27b4b566e52e052a6 (patch) | |
tree | 5ff56d1f1027ae92f212f2a53df889533be5fb64 /net | |
parent | 99f6c40e9ec96b9852f82587468bccf0754f4956 (diff) | |
download | chromium_src-510f705cfeaa21a3c3e768e27b4b566e52e052a6.zip chromium_src-510f705cfeaa21a3c3e768e27b4b566e52e052a6.tar.gz chromium_src-510f705cfeaa21a3c3e768e27b4b566e52e052a6.tar.bz2 |
Fix miss counting on http cache transactions.
Loads bypassing the cache were counting as misses; this was bad for two reasons. Firstly, we were overcounting misses. Secondly, this was making misses look too performant.
This fix was actually uploaded in https://codereview.chromium.org/11637007/ , but in all the debate about the histograms in that patch, this fix got missed. Here it is again, all by itself.
R=rvargas@chromium.org
BUG=None
Review URL: https://chromiumcodereview.appspot.com/11741034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175203 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net')
-rw-r--r-- | net/http/http_cache_transaction.cc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/http/http_cache_transaction.cc b/net/http/http_cache_transaction.cc index 8edce00..27792a1 100644 --- a/net/http/http_cache_transaction.cc +++ b/net/http/http_cache_transaction.cc @@ -732,6 +732,7 @@ int HttpCache::Transaction::DoGetBackendComplete(int result) { if (effective_load_flags_ & LOAD_ONLY_FROM_CACHE) { mode_ = READ; } else if (effective_load_flags_ & LOAD_BYPASS_CACHE) { + UpdateTransactionPattern(PATTERN_NOT_COVERED); mode_ = WRITE; } else { mode_ = READ_WRITE; |