diff options
| author | jam <jam@chromium.org> | 2015-12-10 18:23:27 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-12-11 02:24:09 +0000 |
| commit | 5ccf985d5e5b53f9196b85e147e9c290a648d7da (patch) | |
| tree | 08a7bcdb2a1c2013a9feba742b920c9fbdcb3233 /net | |
| parent | 2b9c4739f033034356590ef9b15f58d4fddcd08b (diff) | |
| download | chromium_src-5ccf985d5e5b53f9196b85e147e9c290a648d7da.zip chromium_src-5ccf985d5e5b53f9196b85e147e9c290a648d7da.tar.gz chromium_src-5ccf985d5e5b53f9196b85e147e9c290a648d7da.tar.bz2 | |
Remove the NoAtExitBaseTestSuite anti-pattern.
A bunch of unit tests were deriving from base::TestSuite and telling it to not create an AtExitManager, while at the same time they were creating an AtExitManager. Just use the base::TestSuite directly which creates the AtExitManager. This follows similar cleanup I did in r362157.
Review URL: https://codereview.chromium.org/1512053002
Cr-Commit-Position: refs/heads/master@{#364590}
Diffstat (limited to 'net')
| -rw-r--r-- | net/test/net_test_suite.cc | 5 | ||||
| -rw-r--r-- | net/test/net_test_suite.h | 5 |
2 files changed, 0 insertions, 10 deletions
diff --git a/net/test/net_test_suite.cc b/net/test/net_test_suite.cc index b14e3fe..a657d26 100644 --- a/net/test/net_test_suite.cc +++ b/net/test/net_test_suite.cc @@ -24,11 +24,6 @@ NetTestSuite::NetTestSuite(int argc, char** argv) : TestSuite(argc, argv) { } -NetTestSuite::NetTestSuite(int argc, char** argv, - bool create_at_exit_manager) - : TestSuite(argc, argv, create_at_exit_manager) { -} - NetTestSuite::~NetTestSuite() {} void NetTestSuite::Initialize() { diff --git a/net/test/net_test_suite.h b/net/test/net_test_suite.h index e0f601e..92f079c 100644 --- a/net/test/net_test_suite.h +++ b/net/test/net_test_suite.h @@ -28,11 +28,6 @@ class NetTestSuite : public base::TestSuite { void Shutdown() override; protected: - // This constructor is only accessible to specialized net test - // implementations which need to control the creation of an AtExitManager - // instance for the duration of the test. - NetTestSuite(int argc, char** argv, bool create_at_exit_manager); - // Called from within Initialize(), but separate so that derived classes // can initialize the NetTestSuite instance only and not // TestSuite::Initialize(). TestSuite::Initialize() performs some global |