Add more out of line copy ctors for complex classes.

This patch adds the remaining copy constructors for complex classes.
After this patch, it should be possible to enable the heavy class copy
constructor checks by default.

R=thakis@chromium.org, dcheng@chromium.org
TBR=jam@chromium.org
BUG=436357
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1825273002

Cr-Commit-Position: refs/heads/master@{#383131}

10 files changed, 20 insertions, 0 deletions

diff --git a/net/cert/signed_tree_head.cc b/net/cert/signed_tree_head.cc
index b430b37..8bf2b9f 100644
--- a/net/cert/signed_tree_head.cc
+++ b/net/cert/signed_tree_head.cc
@@ -29,6 +29,8 @@ SignedTreeHead::SignedTreeHead(Version version,
   memcpy(this->sha256_root_hash, sha256_root_hash, kSthRootHashLength);
 }
 
+SignedTreeHead::SignedTreeHead(const SignedTreeHead& other) = default;
+
 SignedTreeHead::~SignedTreeHead() {}
 
 void PrintTo(const SignedTreeHead& sth, std::ostream* os) {
diff --git a/net/cert/signed_tree_head.h b/net/cert/signed_tree_head.h
index 73b6fdc..154c7a9 100644
--- a/net/cert/signed_tree_head.h
+++ b/net/cert/signed_tree_head.h
@@ -36,6 +36,7 @@ struct NET_EXPORT SignedTreeHead {
                  const char sha256_root_hash[kSthRootHashLength],
                  const DigitallySigned& signature,
                  const std::string& log_id);
+  SignedTreeHead(const SignedTreeHead& other);
   ~SignedTreeHead();
 
   Version version;
diff --git a/net/cookies/cookie_monster_store_test.cc b/net/cookies/cookie_monster_store_test.cc
index 54fe5c4..69f333a 100644
--- a/net/cookies/cookie_monster_store_test.cc
+++ b/net/cookies/cookie_monster_store_test.cc
@@ -34,6 +34,9 @@ CookieStoreCommand::CookieStoreCommand(
 CookieStoreCommand::CookieStoreCommand(Type type, const CanonicalCookie& cookie)
     : type(type), cookie(cookie) {}
 
+CookieStoreCommand::CookieStoreCommand(const CookieStoreCommand& other) =
+    default;
+
 CookieStoreCommand::~CookieStoreCommand() {}
 
 MockPersistentCookieStore::MockPersistentCookieStore()
diff --git a/net/cookies/cookie_monster_store_test.h b/net/cookies/cookie_monster_store_test.h
index e20584d..4458c6c 100644
--- a/net/cookies/cookie_monster_store_test.h
+++ b/net/cookies/cookie_monster_store_test.h
@@ -73,6 +73,8 @@ struct CookieStoreCommand {
   // Constructor for ADD, UPDATE_ACCESS_TIME, and REMOVE calls.
   CookieStoreCommand(Type type, const CanonicalCookie& cookie);
 
+  CookieStoreCommand(const CookieStoreCommand& other);
+
   ~CookieStoreCommand();
 
   Type type;
diff --git a/net/quic/crypto/quic_compressed_certs_cache.cc b/net/quic/crypto/quic_compressed_certs_cache.cc
index 1b6d55b..e4dffaf 100644
--- a/net/quic/crypto/quic_compressed_certs_cache.cc
+++ b/net/quic/crypto/quic_compressed_certs_cache.cc
@@ -38,6 +38,9 @@ QuicCompressedCertsCache::CachedCerts::CachedCerts(
       client_cached_cert_hashes_(*uncompressed_certs.client_cached_cert_hashes),
       compressed_cert_(compressed_cert) {}
 
+QuicCompressedCertsCache::CachedCerts::CachedCerts(const CachedCerts& other) =
+    default;
+
 QuicCompressedCertsCache::CachedCerts::~CachedCerts() {}
 
 bool QuicCompressedCertsCache::CachedCerts::MatchesUncompressedCerts(
diff --git a/net/quic/crypto/quic_compressed_certs_cache.h b/net/quic/crypto/quic_compressed_certs_cache.h
index 5bb0cf4..1a731c8 100644
--- a/net/quic/crypto/quic_compressed_certs_cache.h
+++ b/net/quic/crypto/quic_compressed_certs_cache.h
@@ -74,6 +74,7 @@ class NET_EXPORT_PRIVATE QuicCompressedCertsCache {
     CachedCerts();
     CachedCerts(const UncompressedCerts& uncompressed_certs,
                 const string& compressed_cert);
+    CachedCerts(const CachedCerts& other);
 
     ~CachedCerts();
 
diff --git a/net/quic/crypto/quic_crypto_server_config.cc b/net/quic/crypto/quic_crypto_server_config.cc
index 3ef62d2..c6d32e5 100644
--- a/net/quic/crypto/quic_crypto_server_config.cc
+++ b/net/quic/crypto/quic_crypto_server_config.cc
@@ -205,6 +205,9 @@ QuicCryptoServerConfig::ConfigOptions::ConfigOptions()
       token_binding_enabled(false),
       p256(false) {}
 
+QuicCryptoServerConfig::ConfigOptions::ConfigOptions(
+    const ConfigOptions& other) = default;
+
 QuicCryptoServerConfig::QuicCryptoServerConfig(
     StringPiece source_address_token_secret,
     QuicRandom* server_nonce_entropy,
diff --git a/net/quic/crypto/quic_crypto_server_config.h b/net/quic/crypto/quic_crypto_server_config.h
index ead0c3f..33f088d 100644
--- a/net/quic/crypto/quic_crypto_server_config.h
+++ b/net/quic/crypto/quic_crypto_server_config.h
@@ -125,6 +125,7 @@ class NET_EXPORT_PRIVATE QuicCryptoServerConfig {
   // ConfigOptions contains options for generating server configs.
   struct NET_EXPORT_PRIVATE ConfigOptions {
     ConfigOptions();
+    ConfigOptions(const ConfigOptions& other);
 
     // expiry_time is the time, in UNIX seconds, when the server config will
     // expire. If unset, it defaults to the current time plus six months.
diff --git a/net/socket/socket_test_util.cc b/net/socket/socket_test_util.cc
index e078b0d..a3c57f3 100644
--- a/net/socket/socket_test_util.cc
+++ b/net/socket/socket_test_util.cc
@@ -294,6 +294,9 @@ SSLSocketDataProvider::SSLSocketDataProvider(IoMode mode, int result)
   SSLConnectionStatusSetCipherSuite(0xcc14, &connection_status);
 }
 
+SSLSocketDataProvider::SSLSocketDataProvider(
+    const SSLSocketDataProvider& other) = default;
+
 SSLSocketDataProvider::~SSLSocketDataProvider() {
 }
 
diff --git a/net/socket/socket_test_util.h b/net/socket/socket_test_util.h
index d06ee00..2939b23 100644
--- a/net/socket/socket_test_util.h
+++ b/net/socket/socket_test_util.h
@@ -349,6 +349,7 @@ class StaticSocketDataProvider : public SocketDataProvider {
 // to Connect().
 struct SSLSocketDataProvider {
   SSLSocketDataProvider(IoMode mode, int result);
+  SSLSocketDataProvider(const SSLSocketDataProvider& other);
   ~SSLSocketDataProvider();
 
   void SetNextProto(NextProto proto);