diff options
| author | jochen@chromium.org <jochen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-20 12:57:09 +0000 |
|---|---|---|
| committer | jochen@chromium.org <jochen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-20 12:57:09 +0000 |
| commit | d23bc2d193ef4c98831a21e94c979dc055f1ef97 (patch) | |
| tree | 9ffc9dbd30b8622ef3c4efce4b9c93863ac97ef7 /net | |
| parent | b7cebb01cbf4cd60451244bcf512634bbf64d46d (diff) | |
| download | chromium_src-d23bc2d193ef4c98831a21e94c979dc055f1ef97.zip chromium_src-d23bc2d193ef4c98831a21e94c979dc055f1ef97.tar.gz chromium_src-d23bc2d193ef4c98831a21e94c979dc055f1ef97.tar.bz2 | |
Revert 241883 "Revert 241876 "Add a check that we don't send a s..."
Fixed the incorrect referrer handling in r242082
> Revert 241876 "Add a check that we don't send a secure referrer ..."
>
> This change looks like it broke ReferrerPolicyTest.History
>
> > Add a check that we don't send a secure referrer to an insecure URL
> >
> > Unless one of the non-default referrer policies is set, this should
> > never happen.
> >
> > BUG=none
> > R=mef@chromium.org
> >
> > Review URL: https://codereview.chromium.org/115803003
>
> TBR=jochen@chromium.org
>
> Review URL: https://codereview.chromium.org/118473005
TBR=courage@chromium.org
Review URL: https://codereview.chromium.org/118293004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242084 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net')
| -rw-r--r-- | net/url_request/url_request.cc | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/net/url_request/url_request.cc b/net/url_request/url_request.cc index 6b01247..a037063 100644 --- a/net/url_request/url_request.cc +++ b/net/url_request/url_request.cc @@ -8,6 +8,7 @@ #include "base/bind_helpers.h" #include "base/callback.h" #include "base/compiler_specific.h" +#include "base/debug/dump_without_crashing.h" #include "base/debug/stack_trace.h" #include "base/lazy_instance.h" #include "base/memory/singleton.h" @@ -684,6 +685,17 @@ void URLRequest::StartJob(URLRequestJob* job) { response_info_.was_cached = false; + // If the referrer is secure, but the requested URL is not, the referrer + // policy should be something non-default. If you hit this, please file a + // bug. + if (referrer_policy_ == + CLEAR_REFERRER_ON_TRANSITION_FROM_SECURE_TO_INSECURE && + GURL(referrer_).SchemeIsSecure() && !url().SchemeIsSecure()) { + DLOG(FATAL) << "Trying to send secure referrer for insecure load"; + base::debug::DumpWithoutCrashing(); + referrer_.clear(); + } + // Don't allow errors to be sent from within Start(). // TODO(brettw) this may cause NotifyDone to be sent synchronously, // we probably don't want this: they should be sent asynchronously so |