diff options
| author | vadimt <vadimt@chromium.org> | 2015-01-07 15:51:36 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-01-07 23:52:36 +0000 |
| commit | fdfb872f469245bf9d4205893293316a46c95ff5 (patch) | |
| tree | db3745bf89bc98c5a62fcc3578a23b976be14fba /net | |
| parent | 98b86ee0d0071bdfc5ec8c301a2fb257c05eb007 (diff) | |
| download | chromium_src-fdfb872f469245bf9d4205893293316a46c95ff5.zip chromium_src-fdfb872f469245bf9d4205893293316a46c95ff5.tar.gz chromium_src-fdfb872f469245bf9d4205893293316a46c95ff5.tar.bz2 | |
Instrumenting internals of TCPSocketWin::DoConnect to find jank
Instrumentations showed that:
436634 TCPClientSocket::DoConnect2 = 8.6 jph
Instrumenting further.
BUG=436634
Review URL: https://codereview.chromium.org/830943003
Cr-Commit-Position: refs/heads/master@{#310413}
Diffstat (limited to 'net')
| -rw-r--r-- | net/socket/tcp_socket_win.cc | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/net/socket/tcp_socket_win.cc b/net/socket/tcp_socket_win.cc index 0c3d26f..1a4f2e8 100644 --- a/net/socket/tcp_socket_win.cc +++ b/net/socket/tcp_socket_win.cc @@ -425,6 +425,10 @@ int TCPSocketWin::Accept(scoped_ptr<TCPSocketWin>* socket, int TCPSocketWin::Connect(const IPEndPoint& address, const CompletionCallback& callback) { + // TODO(vadimt): Remove ScopedTracker below once crbug.com/436634 is fixed. + tracked_objects::ScopedTracker tracking_profile( + FROM_HERE_WITH_EXPLICIT_FUNCTION("436634 TCPSocketWin::Connect")); + DCHECK(CalledOnValidThread()); DCHECK_NE(socket_, INVALID_SOCKET); DCHECK(!waiting_connect_); @@ -797,6 +801,10 @@ void TCPSocketWin::OnObjectSignaled(HANDLE object) { } int TCPSocketWin::DoConnect() { + // TODO(vadimt): Remove ScopedTracker below once crbug.com/436634 is fixed. + tracked_objects::ScopedTracker tracking_profile( + FROM_HERE_WITH_EXPLICIT_FUNCTION("436634 TCPSocketWin::DoConnect")); + DCHECK_EQ(connect_os_error_, 0); DCHECK(!core_.get()); |