diff options
| author | tschmelcher@chromium.org <tschmelcher@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-05 22:06:28 +0000 |
|---|---|---|
| committer | tschmelcher@chromium.org <tschmelcher@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-05 22:06:28 +0000 |
| commit | 7abe40d5e82e695c4c5a6379c5e9d1ebe090bd76 (patch) | |
| tree | 7f6470719ac6659dd980e60c695658d8b8e2b956 /o3d/breakpad/breakpad.gyp | |
| parent | 07a3c8554aa3f329264766249c22beaa6d7e394e (diff) | |
| download | chromium_src-7abe40d5e82e695c4c5a6379c5e9d1ebe090bd76.zip chromium_src-7abe40d5e82e695c4c5a6379c5e9d1ebe090bd76.tar.gz chromium_src-7abe40d5e82e695c4c5a6379c5e9d1ebe090bd76.tar.bz2 | |
Fix multiple bugs preventing Windows crash uploading from working:
1) The code to initialize breakpad was guarded by an ifdef on O3D_ENABLE_BREAKPAD, which is never defined anywhere, so the feature was disabled.
2) The version string used the macro O3D_VERSION_NUMBER, which is never defined anywhere, so it sent the literal string "O3D_VERSION_NUMBER".
3) The upload URLs were outdated (though it seems the old ones are actually still functional).
TEST=added a deliberate crash and verified that it successfully uploads to the crash server
BUG=none
Review URL: http://codereview.chromium.org/3077026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55142 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'o3d/breakpad/breakpad.gyp')
| -rw-r--r-- | o3d/breakpad/breakpad.gyp | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/o3d/breakpad/breakpad.gyp b/o3d/breakpad/breakpad.gyp index 7099432..d5cdd907 100644 --- a/o3d/breakpad/breakpad.gyp +++ b/o3d/breakpad/breakpad.gyp @@ -9,6 +9,7 @@ 'includes': [ '../build/branding.gypi', '../build/common.gypi', + '../build/version.gypi', ], 'target_defaults': { 'include_dirs': [ @@ -17,6 +18,7 @@ '../../breakpad/src', ], 'defines': [ + 'O3D_PLUGIN_VERSION="<(plugin_version)"', 'O3D_PLUGIN_INSTALLDIR_CSIDL=<(plugin_installdir_csidl)', 'O3D_PLUGIN_VENDOR_DIRECTORY="<(plugin_vendor_directory)"', 'O3D_PLUGIN_PRODUCT_DIRECTORY="<(plugin_product_directory)"', |