diff options
| author | jam <jam@chromium.org> | 2015-02-04 09:40:04 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-02-04 17:41:19 +0000 |
| commit | dc0e4390c0364515fa360c5292a4389784580a48 (patch) | |
| tree | fab0a7f9e043c362b35486aed516966c1a5f0cf9 /pdf/BUILD.gn | |
| parent | d771a782774564197c9c4d3ddd07605e53397a12 (diff) | |
| download | chromium_src-dc0e4390c0364515fa360c5292a4389784580a48.zip chromium_src-dc0e4390c0364515fa360c5292a4389784580a48.tar.gz chromium_src-dc0e4390c0364515fa360c5292a4389784580a48.tar.bz2 | |
Combine PDF plugin into the Chromium binary.
On Windows, this moves it to chrome_child.dll. Overall binary sizes is 4.5 MB smaller (chrome_child.dll gets 3.6 MB larger while we drop the 8.1 MB pdf.dll). On Mac, the binary is 6.6 MB smaller. On Linux, it's 7MB smaller. This is from official release builds, after stripping on Linux.
The size savings are because we don't ship duplicate versions of V8, and also the PDF plugin uses some of base and net.
This depends on OOP PDF, since otherwise the V8 isolates for the plugin and Blink interact badly. That got turned on a few weeks ago.
BUG=453844
Review URL: https://codereview.chromium.org/799643004
Cr-Commit-Position: refs/heads/master@{#314575}
Diffstat (limited to 'pdf/BUILD.gn')
| -rw-r--r-- | pdf/BUILD.gn | 30 |
1 files changed, 4 insertions, 26 deletions
diff --git a/pdf/BUILD.gn b/pdf/BUILD.gn index b028290..4ecd961 100644 --- a/pdf/BUILD.gn +++ b/pdf/BUILD.gn @@ -4,8 +4,7 @@ pdf_engine = 0 # 0 PDFium -# TODO(GYP) need support for loadable modules -shared_library("pdf") { +static_library("pdf") { sources = [ "button.h", "button.cc", @@ -35,7 +34,6 @@ shared_library("pdf") { "paint_manager.h", "pdf.cc", "pdf.h", - "pdf.rc", "progress_control.cc", "progress_control.h", "pdf_engine.h", @@ -45,8 +43,6 @@ shared_library("pdf") { "resource_consts.h", "thumbnail_control.cc", "thumbnail_control.h", - "../components/ui/zoom/page_zoom_constants.cc", - "../content/common/page_zoom.cc", ] if (pdf_engine == 0) { @@ -68,33 +64,15 @@ shared_library("pdf") { } if (is_win) { - defines = [ "COMPILE_CONTENT_STATICALLY" ] cflags = [ "/wd4267" ] # TODO(jschuh) size_t to int truncations. } - if (is_mac) { - # TODO(GYP) - #'mac_bundle': 1, - #'product_name': 'PDF', - #'product_extension': 'plugin', - ## Strip the shipping binary of symbols so "Foxit" doesn't appear in - ## the binary. Symbols are stored in a separate .dSYM. - #'variables': { - # 'mac_real_dsym': 1, - #}, - #'sources+': [ - # 'Info.plist' - #] - #'xcode_settings': { - # 'INFOPLIST_FILE': 'Info.plist', - #}, - } - deps = [ "//base", + "//components/ui/zoom:ui_zoom", + "//content/public/common", "//net", - "//ppapi:ppapi_cpp", + "//ppapi:ppapi_internal_module", "//third_party/pdfium", ] } -# TODO(GYP) pdf_linux_symbols target. |