diff options
| author | tsepez <tsepez@chromium.org> | 2014-09-04 22:42:28 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-09-05 05:44:07 +0000 |
| commit | 8f07983fb62fb48fc8298b150e4548f92a374da1 (patch) | |
| tree | 846026a4dfbb29bfd195eb3ea67acdd8a7dffea4 /pdf/draw_utils.h | |
| parent | 37fac505ffd432f088abbc5056e7c72ca59ff017 (diff) | |
| download | chromium_src-8f07983fb62fb48fc8298b150e4548f92a374da1.zip chromium_src-8f07983fb62fb48fc8298b150e4548f92a374da1.tar.gz chromium_src-8f07983fb62fb48fc8298b150e4548f92a374da1.tar.bz2 | |
Preven OOB memory access in chrome_pdf::AlphaBlend().
Similar to bug 398384, but perform the same bounds check we introduced to
chrome_pdf::CopyImage() in the chrome_pdf::AlphaBlend() function.
Also change the return value from bool to void, since AlphaBlend() always
returns true, and no-one was checking the return value anyways.
BUG=384891
Review URL: https://codereview.chromium.org/544863002
Cr-Commit-Position: refs/heads/master@{#293454}
Diffstat (limited to 'pdf/draw_utils.h')
| -rw-r--r-- | pdf/draw_utils.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/pdf/draw_utils.h b/pdf/draw_utils.h index 1024037..eedf24f 100644 --- a/pdf/draw_utils.h +++ b/pdf/draw_utils.h @@ -16,7 +16,7 @@ namespace chrome_pdf { const uint8 kOpaqueAlpha = 0xFF; const uint8 kTransparentAlpha = 0x00; -bool AlphaBlend(const pp::ImageData& src, const pp::Rect& src_rc, +void AlphaBlend(const pp::ImageData& src, const pp::Rect& src_rc, pp::ImageData* dest, const pp::Point& dest_origin, uint8 alpha_adjustment); |