summaryrefslogtreecommitdiffstats
path: root/pdf/out_of_process_instance.cc
diff options
context:
space:
mode:
authortsepez <tsepez@chromium.org>2014-12-29 11:04:41 -0800
committerCommit bot <commit-bot@chromium.org>2014-12-29 19:05:22 +0000
commit3c703774c2958ebd2b1f877725900232fc3a4c1f (patch)
tree3175a8fd216ec89430e9b66367328755cf632aa6 /pdf/out_of_process_instance.cc
parent17131836072e4213043ccaa9df22de89f8ab04eb (diff)
downloadchromium_src-3c703774c2958ebd2b1f877725900232fc3a4c1f.zip
chromium_src-3c703774c2958ebd2b1f877725900232fc3a4c1f.tar.gz
chromium_src-3c703774c2958ebd2b1f877725900232fc3a4c1f.tar.bz2
Load V8 external data prior to initializng PDFium SDK.
Under XFA, PDFium will always attempt to start V8 as part of the SDK initialization, and will segv if the external data has not yet been loaded. BUG=439793 Review URL: https://codereview.chromium.org/819473002 Cr-Commit-Position: refs/heads/master@{#309712}
Diffstat (limited to 'pdf/out_of_process_instance.cc')
-rw-r--r--pdf/out_of_process_instance.cc10
1 files changed, 0 insertions, 10 deletions
diff --git a/pdf/out_of_process_instance.cc b/pdf/out_of_process_instance.cc
index 34ed32a..59b0439 100644
--- a/pdf/out_of_process_instance.cc
+++ b/pdf/out_of_process_instance.cc
@@ -40,7 +40,6 @@
#include "ppapi/cpp/var_array.h"
#include "ppapi/cpp/var_dictionary.h"
#include "ui/events/keycodes/keyboard_codes.h"
-#include "v8/include/v8.h"
namespace chrome_pdf {
@@ -278,15 +277,6 @@ OutOfProcessInstance::~OutOfProcessInstance() {
bool OutOfProcessInstance::Init(uint32_t argc,
const char* argn[],
const char* argv[]) {
- v8::StartupData natives;
- v8::StartupData snapshot;
- pp::PDF::GetV8ExternalSnapshotData(this, &natives.data, &natives.raw_size,
- &snapshot.data, &snapshot.raw_size);
- if (natives.data) {
- v8::V8::SetNativesDataBlob(&natives);
- v8::V8::SetSnapshotDataBlob(&snapshot);
- }
-
// Check if the PDF is being loaded in the PDF chrome extension. We only allow
// the plugin to be put into "full frame" mode when it is being loaded in the
// extension because this enables some features that we don't want pages