diff options
author | raymes@chromium.org <raymes@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-19 12:08:05 +0000 |
---|---|---|
committer | raymes@chromium.org <raymes@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-19 12:08:05 +0000 |
commit | 691fd025f43cd24311e55d62f2720cb7c39dc971 (patch) | |
tree | 3f2a81d816bf71c0c4c2285bb74739a570d31592 /pdf/out_of_process_instance.cc | |
parent | f7e98cae026f036fd9c94708abb5b21c3617ba56 (diff) | |
download | chromium_src-691fd025f43cd24311e55d62f2720cb7c39dc971.zip chromium_src-691fd025f43cd24311e55d62f2720cb7c39dc971.tar.gz chromium_src-691fd025f43cd24311e55d62f2720cb7c39dc971.tar.bz2 |
Re-enable PDFExtensionTest.BasicPlugin
This test was disabled because it was failing. A few changes have been made:
-The page zoom cannot be assumed to be 100% on load as it will depend on the screen size being tested on. So testPageSize now doesn't make that assumption.
-testAccessibilityWithPage was flaking because accessibility information was not always returned for the two text boxes. I spent a bit of time investigating, but couldn't work it out so I've left it partially disabled for now and filed crbug.com/378091.
-The files have all been moved to a more appropriate location (in particular the test was moved out of the data directory).
BUG=303491
Review URL: https://codereview.chromium.org/290803007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278340 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'pdf/out_of_process_instance.cc')
-rw-r--r-- | pdf/out_of_process_instance.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/pdf/out_of_process_instance.cc b/pdf/out_of_process_instance.cc index 8a692c9..9e77ec6 100644 --- a/pdf/out_of_process_instance.cc +++ b/pdf/out_of_process_instance.cc @@ -408,7 +408,7 @@ void OutOfProcessInstance::HandleMessage(const pp::Var& message) { pp::VarDictionary reply; reply.Set(pp::Var(kType), pp::Var(kJSGetAccessibilityJSONReplyType)); if (dict.Get(pp::Var(kJSAccessibilityPageNumber)).is_int()) { - int page = pp::Var(kJSAccessibilityPageNumber).AsInt(); + int page = dict.Get(pp::Var(kJSAccessibilityPageNumber)).AsInt(); reply.Set(pp::Var(kJSAccessibilityJSON), pp::Var(engine_->GetPageAsJSON(page))); } else { |