diff options
| author | raymes@chromium.org <raymes@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-02 08:15:49 +0000 |
|---|---|---|
| committer | raymes@chromium.org <raymes@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-02 08:15:49 +0000 |
| commit | ec7f257adc93d71a4c5535108142be848ff84fc9 (patch) | |
| tree | 6b566dd92e8c1c615191632ac7304a0fab06e98f /pdf/out_of_process_instance.cc | |
| parent | 1f9532b4910b25577e34f30242294764552d8fe3 (diff) | |
| download | chromium_src-ec7f257adc93d71a4c5535108142be848ff84fc9.zip chromium_src-ec7f257adc93d71a4c5535108142be848ff84fc9.tar.gz chromium_src-ec7f257adc93d71a4c5535108142be848ff84fc9.tar.bz2 | |
Re-enable PDFExtensionTest.BasicPlugin
This test was disabled because it was failing. A few changes have been made:
-The page zoom cannot be assumed to be 100% on load as it will depend on the screen size being tested on. So testPageSize now doesn't make that assumption.
-testAccessibilityWithPage was flaking because accessibility information was not always returned for the two text boxes. I spent a bit of time investigating, but couldn't work it out so I've left it partially disabled for now and filed crbug.com/378091.
-The files have all been moved to a more appropriate location (in particular the test was moved out of the data directory).
BUG=303491
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273819
Review URL: https://codereview.chromium.org/290803007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274186 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'pdf/out_of_process_instance.cc')
| -rw-r--r-- | pdf/out_of_process_instance.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/pdf/out_of_process_instance.cc b/pdf/out_of_process_instance.cc index 49b14ee..47fa4e1 100644 --- a/pdf/out_of_process_instance.cc +++ b/pdf/out_of_process_instance.cc @@ -407,7 +407,7 @@ void OutOfProcessInstance::HandleMessage(const pp::Var& message) { pp::VarDictionary reply; reply.Set(pp::Var(kType), pp::Var(kJSGetAccessibilityJSONReplyType)); if (dict.Get(pp::Var(kJSAccessibilityPageNumber)).is_int()) { - int page = pp::Var(kJSAccessibilityPageNumber).AsInt(); + int page = dict.Get(pp::Var(kJSAccessibilityPageNumber)).AsInt(); reply.Set(pp::Var(kJSAccessibilityJSON), pp::Var(engine_->GetPageAsJSON(page))); } else { |