diff options
| author | teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-10 18:40:07 +0000 |
|---|---|---|
| committer | teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-10 18:40:07 +0000 |
| commit | 83277226b5fa03ba72552ccaff113d714148105c (patch) | |
| tree | e5467da5be8374f255f492699b0db001a11436a3 /ppapi/api | |
| parent | a802ee161b0a0bb782b0d6960a4728ee57a44454 (diff) | |
| download | chromium_src-83277226b5fa03ba72552ccaff113d714148105c.zip chromium_src-83277226b5fa03ba72552ccaff113d714148105c.tar.gz chromium_src-83277226b5fa03ba72552ccaff113d714148105c.tar.bz2 | |
Pepper: Fix comments for PPB and PPP InputEvent.
The comments provided in PPB_InputEvent and PPP_InputEvent incorrectly describe
how handled events are delivered to handlers in web pages.
When a plugin handles an event, the event is not "bubbled" to any default
handlers. However, any listeners in a web page run before the event reaches the
plugin, so the plugin can't prevent any listeners from getting the event.
An attempt to make the implementation match the specification broke existing
plugins, so the only reasonable approach is to make the comments match the
behavior.
BUG=324352
R=dmichael@chromium.org
Review URL: https://codereview.chromium.org/228653006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263034 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi/api')
| -rw-r--r-- | ppapi/api/ppb_input_event.idl | 8 | ||||
| -rw-r--r-- | ppapi/api/ppp_input_event.idl | 8 |
2 files changed, 7 insertions, 9 deletions
diff --git a/ppapi/api/ppb_input_event.idl b/ppapi/api/ppb_input_event.idl index d871a76..b9224fa 100644 --- a/ppapi/api/ppb_input_event.idl +++ b/ppapi/api/ppb_input_event.idl @@ -316,9 +316,7 @@ interface PPB_InputEvent { * (and only if) you do not request touch events. * * When requesting input events through this function, the events will be - * delivered and <i>not</i> bubbled to the page. This means that even if you - * aren't interested in the message, no other parts of the page will get - * a crack at the message. + * delivered and <i>not</i> bubbled to the default handlers. * * <strong>Example:</strong> * @code @@ -353,8 +351,8 @@ interface PPB_InputEvent { * By default, no input events are delivered. In most cases you would * register to receive events by calling RequestInputEvents(). In some cases, * however, you may wish to filter events such that they can be bubbled up - * to the DOM. In this case, register for those classes of events using - * this function instead of RequestInputEvents(). + * to the default handlers. In this case, register for those classes of + * events using this function instead of RequestInputEvents(). * * Filtering input events requires significantly more overhead than just * delivering them to the instance. As such, you should only request diff --git a/ppapi/api/ppp_input_event.idl b/ppapi/api/ppp_input_event.idl index a7efb5b..97285c2 100644 --- a/ppapi/api/ppp_input_event.idl +++ b/ppapi/api/ppp_input_event.idl @@ -20,10 +20,10 @@ interface PPP_InputEvent { * PPB_InputEvent.RequestInputEvents() or RequestFilteringInputEvents(). By * default, no events are delivered. * - * If the event was handled, it will not be forwarded to the web page or - * browser. If it was not handled, it will bubble according to the normal - * rules. So it is important that an instance respond accurately with whether - * event propagation should continue. + * If the event was handled, it will not be forwarded to the default handlers + * in the web page. If it was not handled, it may be dispatched to a default + * handler. So it is important that an instance respond accurately with + * whether event propagation should continue. * * Event propagation also controls focus. If you handle an event like a mouse * event, typically the instance will be given focus. Returning false from |