diff options
| author | Justin TerAvest <teravest@chromium.org> | 2014-09-04 08:41:18 -0600 |
|---|---|---|
| committer | Justin TerAvest <teravest@chromium.org> | 2014-09-04 14:43:17 +0000 |
| commit | f3e9e0cb8d6dc6f0a6f5cec9180c0e538e76c184 (patch) | |
| tree | 21d6182aeca9314163b1930f8ae07efda4a72485 /ppapi/c/private | |
| parent | c6df10449518e58f647ea40f5907041bb54639f8 (diff) | |
| download | chromium_src-f3e9e0cb8d6dc6f0a6f5cec9180c0e538e76c184.zip chromium_src-f3e9e0cb8d6dc6f0a6f5cec9180c0e538e76c184.tar.gz chromium_src-f3e9e0cb8d6dc6f0a6f5cec9180c0e538e76c184.tar.bz2 | |
NaCl: Detect plugin crashes via EOF on Chromium IPC.
This change uses the OnChannelError() callback in TrustedPluginChannel to
detect that the channel between the renderer and NaCl processes has closed.
Previously, closure of the SRPC channel between those two processes was used to
indicate a plugin crash.
I wasn't sure at first that OnChannelError() would be called, but it appears to
be called reliably in the testing that I've done.
This change removes a call to ReportCrash() in ServiceRuntime::ReapLogs() since
ReportCrash() has become a no-op.
This change reenables the NaClBrowserTest*.Crash tests on Linux to ensure that
there's good coverage-- they seem to pass.
TEST=NaClBrowserTest*.Crash
BUG=366334,401105
R=mseaborn@chromium.org
Review URL: https://codereview.chromium.org/512323002
Cr-Commit-Position: refs/heads/master@{#293297}
Diffstat (limited to 'ppapi/c/private')
| -rw-r--r-- | ppapi/c/private/ppb_nacl_private.h | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/ppapi/c/private/ppb_nacl_private.h b/ppapi/c/private/ppb_nacl_private.h index b28dff2..5ba08d9 100644 --- a/ppapi/c/private/ppb_nacl_private.h +++ b/ppapi/c/private/ppb_nacl_private.h @@ -3,7 +3,7 @@ * found in the LICENSE file. */ -/* From private/ppb_nacl_private.idl modified Wed Aug 27 13:55:13 2014. */ +/* From private/ppb_nacl_private.idl modified Thu Sep 4 07:46:02 2014. */ #ifndef PPAPI_C_PRIVATE_PPB_NACL_PRIVATE_H_ #define PPAPI_C_PRIVATE_PPB_NACL_PRIVATE_H_ @@ -304,8 +304,6 @@ struct PPB_NaCl_Private_1_0 { const char* error_message); /* Reports that loading a nexe was aborted. */ void (*ReportLoadAbort)(PP_Instance instance); - /* Reports that the nexe has crashed. */ - void (*NexeDidCrash)(PP_Instance instance); /* Performs internal setup when an instance is created. */ void (*InstanceCreated)(PP_Instance instance); /* Performs internal cleanup when an instance is destroyed. */ |