diff options
| author | teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-20 20:43:09 +0000 |
|---|---|---|
| committer | teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-20 20:44:12 +0000 |
| commit | c2fa29f5bca0bc8398e4a5c162a44db84f4f6b5a (patch) | |
| tree | 8b2948867d5ce35d75398ea94242d1c6ed079ab0 /ppapi/c | |
| parent | 26dae5835ebed7c8ee0864d44e25b5abcddbae23 (diff) | |
| download | chromium_src-c2fa29f5bca0bc8398e4a5c162a44db84f4f6b5a.zip chromium_src-c2fa29f5bca0bc8398e4a5c162a44db84f4f6b5a.tar.gz chromium_src-c2fa29f5bca0bc8398e4a5c162a44db84f4f6b5a.tar.bz2 | |
NaCl: Send fatal log messages via shared memory.
nacl_helper reports the last few log messages to the renderer when a LOG_FATAL
message is logged in the plugin. This currently uses the "bootstrap" channel,
which we would like to get rid of.
This uses a shared memory segment instead of IPC, since something bad may have
happened in the plugin process, so we'd like to keep the behavior for handling
that case as simple as possible. For that reason, the shared memory segment is
mapped before the nexe is loaded.
I've tested this locally by calling RemoteLog(LOG_FATAL, ...) after StartModule
in ServiceRuntime, though I'd like to find some better way to test this as
there's a decent amount of logic here.
BUG=391039
R=jschuh@chromium.org, mseaborn@chromium.org
Review URL: https://codereview.chromium.org/469423002
Cr-Commit-Position: refs/heads/master@{#290910}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290910 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi/c')
| -rw-r--r-- | ppapi/c/private/ppb_nacl_private.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/ppapi/c/private/ppb_nacl_private.h b/ppapi/c/private/ppb_nacl_private.h index 940979f..67d2939 100644 --- a/ppapi/c/private/ppb_nacl_private.h +++ b/ppapi/c/private/ppb_nacl_private.h @@ -3,7 +3,7 @@ * found in the LICENSE file. */ -/* From private/ppb_nacl_private.idl modified Thu Jul 10 10:34:30 2014. */ +/* From private/ppb_nacl_private.idl modified Thu Aug 14 11:48:23 2014. */ #ifndef PPAPI_C_PRIVATE_PPB_NACL_PRIVATE_H_ #define PPAPI_C_PRIVATE_PPB_NACL_PRIVATE_H_ @@ -305,7 +305,7 @@ struct PPB_NaCl_Private_1_0 { /* Reports that loading a nexe was aborted. */ void (*ReportLoadAbort)(PP_Instance instance); /* Reports that the nexe has crashed. */ - void (*NexeDidCrash)(PP_Instance instance, const char* crash_log); + void (*NexeDidCrash)(PP_Instance instance); /* Performs internal setup when an instance is created. */ void (*InstanceCreated)(PP_Instance instance); /* Performs internal cleanup when an instance is destroyed. */ |