diff options
| author | raymes@chromium.org <raymes@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-18 18:49:47 +0000 |
|---|---|---|
| committer | raymes@chromium.org <raymes@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-18 18:49:47 +0000 |
| commit | d10d2cf2d284daa024deb9a512868c55608dfd1c (patch) | |
| tree | 533d4748d1bf2eb98b12fdfc1b367f7904a05983 /ppapi/c | |
| parent | 5b1840636a2ba72b9de48735ec05125a61759b07 (diff) | |
| download | chromium_src-d10d2cf2d284daa024deb9a512868c55608dfd1c.zip chromium_src-d10d2cf2d284daa024deb9a512868c55608dfd1c.tar.gz chromium_src-d10d2cf2d284daa024deb9a512868c55608dfd1c.tar.bz2 | |
Revert 207040 "Don't send PP_Vars/V8 values with cycles across P..."
> Don't send PP_Vars/V8 values with cycles across PostMessage
>
> This prevents PP_Vars/V8 values with cycles being transmitted across PostMessage. An undefined value will be sent instead and an error will be logged to the console.
>
> BUG=236958
>
> Review URL: https://chromiumcodereview.appspot.com/16140011
TBR=raymes@chromium.org
Review URL: https://codereview.chromium.org/17239007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207043 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi/c')
| -rw-r--r-- | ppapi/c/ppb_messaging.h | 6 | ||||
| -rw-r--r-- | ppapi/c/ppp_messaging.h | 9 |
2 files changed, 8 insertions, 7 deletions
diff --git a/ppapi/c/ppb_messaging.h b/ppapi/c/ppb_messaging.h index 06e31205..404a11c 100644 --- a/ppapi/c/ppb_messaging.h +++ b/ppapi/c/ppb_messaging.h @@ -3,7 +3,7 @@ * found in the LICENSE file. */ -/* From ppb_messaging.idl modified Wed Jun 5 10:32:59 2013. */ +/* From ppb_messaging.idl modified Mon May 20 15:31:07 2013. */ #ifndef PPAPI_C_PPB_MESSAGING_H_ #define PPAPI_C_PPB_MESSAGING_H_ @@ -50,8 +50,8 @@ struct PPB_Messaging_1_0 { * JavaScript. * * When passing array or dictionary <code>PP_Var</code>s, the entire reference - * graph will be converted and transferred. If the reference graph has cycles, - * the message will not be sent and an error will be logged to the console. + * graph will be converted and transferred, including reference cycles if they + * exist. * * Listeners for message events in JavaScript code will receive an object * conforming to the HTML 5 <code>MessageEvent</code> interface. diff --git a/ppapi/c/ppp_messaging.h b/ppapi/c/ppp_messaging.h index 28d40d6..b2e1f3c 100644 --- a/ppapi/c/ppp_messaging.h +++ b/ppapi/c/ppp_messaging.h @@ -3,7 +3,7 @@ * found in the LICENSE file. */ -/* From ppp_messaging.idl modified Wed Jun 5 10:32:43 2013. */ +/* From ppp_messaging.idl modified Tue May 21 09:01:17 2013. */ #ifndef PPAPI_C_PPP_MESSAGING_H_ #define PPAPI_C_PPP_MESSAGING_H_ @@ -52,9 +52,10 @@ struct PPP_Messaging_1_0 { * * When converting JavaScript arrays, any object properties whose name * is not an array index are ignored. When passing arrays and objects, the - * entire reference graph will be converted and transferred. If the reference - * graph has cycles, the message will not be sent and an error will be logged - * to the console. + * entire reference graph will be converted and transferred, including + * reference cycles if they exist. Since <code>PP_Var</code>s are ref-counted, + * the author of the plugin must take care if they expect to receive vars with + * cycles. Cycles must be manually broken to correctly release the vars. * * The following JavaScript code invokes <code>HandleMessage</code>, passing * the module instance on which it was invoked, with <code>message</code> |