summaryrefslogtreecommitdiffstats
path: root/ppapi/native_client/tests
diff options
context:
space:
mode:
authorpolina@google.com <polina@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2011-09-27 04:24:30 +0000
committerpolina@google.com <polina@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2011-09-27 04:24:30 +0000
commit06e0a34ae11c97e35ae67f6a006dc4a45cda58af (patch)
treea6766fa80232f512030a7c68726c5c6137e5a52d /ppapi/native_client/tests
parent325e9d2d3e52b4402c82c9b3c0c2163ef0f09020 (diff)
downloadchromium_src-06e0a34ae11c97e35ae67f6a006dc4a45cda58af.zip
chromium_src-06e0a34ae11c97e35ae67f6a006dc4a45cda58af.tar.gz
chromium_src-06e0a34ae11c97e35ae67f6a006dc4a45cda58af.tar.bz2
Add PPB_Fullscreen_Dev;0.5. Keep 0.4 for backwards compatiblity and point it
to PPB_FlashFullscreen. The new implementation is based on http://codereview.chromium.org/7714017/ with some bug fixes. Update header comments. Main API differences between the old and the new implementation: - transition from fullscreen is now asynchronous and ends at DidChangeView just like transition to fullscreen; graphics devices cannot be bound during the transition. - when switching to/from fullscreen 3D resources no longer need to be re-created. - transitions to fullscreen are only possible when processing user user gestures. - transition to fullscreen results in 2 DidChangeViews, one for moving the plugin to the middle of the window and one for stretching the window and placing the plugin in the middle of the screen. - the size of the plugin is not changed when going to/from fullscreen. Testing: - Mapped ppapi_tests:test_fullscreen to ppapi_tests:test_flash_fullscreen. - Updated test_fullscreen to work with the new implementation. To be testable automatically this needs enhancements to the testing infrastructure for generating user gestures. For now marked the test as DISABLED. - Disabled NaCl's ppapi_ppb_fullscreen_browser_test for the same reasons as above. - To re-enable both tests, we will first need to add user gesture capabilites to PPB_Testing. - Build 0.4 ppapi_test:test_fullscreen and ran this out of process and in process with the newly build revision of chrome to verify backwards compatability. - In a separate CL, will update NaCl's ppapi_ppb_fullscreen_browser_test to work with the new implementation, for now only manually. BUG=41780 TEST=see above Review URL: http://codereview.chromium.org/7826017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102888 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi/native_client/tests')
-rw-r--r--ppapi/native_client/tests/ppapi_browser/ppb_fullscreen/nacl.scons16
1 files changed, 11 insertions, 5 deletions
diff --git a/ppapi/native_client/tests/ppapi_browser/ppb_fullscreen/nacl.scons b/ppapi/native_client/tests/ppapi_browser/ppb_fullscreen/nacl.scons
index c4b3262..128b807 100644
--- a/ppapi/native_client/tests/ppapi_browser/ppb_fullscreen/nacl.scons
+++ b/ppapi/native_client/tests/ppapi_browser/ppb_fullscreen/nacl.scons
@@ -39,8 +39,14 @@ node = env.PPAPIBrowserTester('ppapi_ppb_fullscreen_browser_test.out',
# ERROR:render_widget_host_view_mac.mm(344)] Not implemented reached in virtual
# void RenderWidgetHost ViewMac::InitAsFullscreen(RenderWidgetHostView *)Full
# screen not implemented on Mac
-env.AddNodeToTestSuite(node,
- ['chrome_browser_tests'],
- 'run_ppapi_ppb_fullscreen_browser_test',
- is_broken=(env.PPAPIBrowserTesterIsBroken() or
- env.Bit('host_mac')))
+env.AddNodeToTestSuite(
+ node,
+ ['chrome_browser_tests'],
+ 'run_ppapi_ppb_fullscreen_browser_test',
+ # New PPB_Fullscreen_Dev implementation only allows transitions to
+ # fullscreen after a user gesture. Until PPB_Testing has the capabilities
+ # to trigger those, we cannot test this automatically.
+ # TODO(polina): update the test to work manually with the new
+ # implementation while we are sorting out the above issue.
+ #is_broken=(env.PPAPIBrowserTesterIsBroken() or env.Bit('host_mac')))
+ is_broken=True)