diff options
| author | raymes <raymes@chromium.org> | 2014-09-02 22:51:04 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-09-03 05:52:57 +0000 |
| commit | dc463a9f84db834c51feff23aa46e41dad33c6ff (patch) | |
| tree | 2b974de5773efcf5d29ed26a8f805ec8dd9cc5ac /ppapi/tests/test_post_message.cc | |
| parent | 8b5b6319ddca5d1e2044b99fddc6d3a61a6efd1c (diff) | |
| download | chromium_src-dc463a9f84db834c51feff23aa46e41dad33c6ff.zip chromium_src-dc463a9f84db834c51feff23aa46e41dad33c6ff.tar.gz chromium_src-dc463a9f84db834c51feff23aa46e41dad33c6ff.tar.bz2 | |
Revert of Replace NPObject usage in ppapi with gin (patchset #28 id:540001 of https://codereview.chromium.org/459553003/)
Reason for revert:
Causing a bunch of top crashes:
go/crash/c383c0c43c093ea1
go/crash/576a27ecf5f32094
go/crash/08fc74881d1819ac
go/crash/a6a00150ba55c0bf
Original issue's description:
> Replace NPObject usage in ppapi with gin
>
> This replaces usage of NPObject in pepper with gin-backed V8 objects. It is unfortunate that this CL is so large, but there isn't a nice way to have the old implementation and the new one side-by-side.
>
> There are 4 major parts to this CL:
> 1) Changing the HostVarTracker to track V8ObjectVars rather than NPObjectVars (host_var_tracker.cc).
> 2) Changing plugin elements (in plugin_object.cc) to be gin-backed objects.
> 3) Changing postMessage bindings (message_channel.cc) be gin-backed objects.
> 4) Changing the implementation of PPB_Var_Deprecated (ppb_var_deprecated_impl.cc) to call directly into V8.
>
>
> BUG=351636
>
> Committed: https://chromium.googlesource.com/chromium/src/+/21f446ae855d60cc896b40cb9a3249ed07f150b3
>
> Committed: https://chromium.googlesource.com/chromium/src/+/ee49e63baf57e503bd71dfe61c8a80df63eac9aa
>
> Committed: https://chromium.googlesource.com/chromium/src/+/e06bc5d896e494b9ec556f0e89dcc523778a1432
TBR=jochen@chromium.org,dmichael@chromium.org,kolczyk@opera.com
NOTREECHECKS=true
NOTRY=true
BUG=351636
Review URL: https://codereview.chromium.org/537483002
Cr-Commit-Position: refs/heads/master@{#293079}
Diffstat (limited to 'ppapi/tests/test_post_message.cc')
| -rw-r--r-- | ppapi/tests/test_post_message.cc | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/ppapi/tests/test_post_message.cc b/ppapi/tests/test_post_message.cc index 6a415bb..5413b54 100644 --- a/ppapi/tests/test_post_message.cc +++ b/ppapi/tests/test_post_message.cc @@ -172,14 +172,6 @@ TestPostMessage::~TestPostMessage() { bool TestPostMessage::Init() { bool success = CheckTestingInterface(); - // Add a post condition to tests which caches the postMessage function and - // then calls it after the instance is destroyed. The ensures that no UAF - // occurs because the MessageChannel may still be alive after the plugin - // instance is destroyed (it will get garbage collected eventually). - instance_->EvalScript("window.pluginPostMessage = " - "document.getElementById('plugin').postMessage"); - instance_->AddPostCondition("window.pluginPostMessage('') === undefined"); - // Set up a special listener that only responds to a FINISHED_WAITING string. // This is for use by WaitForMessages. std::string js_code; |