summaryrefslogtreecommitdiffstats
path: root/ppapi/tests/test_printing.h
diff options
context:
space:
mode:
authorsashab <sashab@chromium.org>2015-11-05 15:00:04 -0800
committerCommit bot <commit-bot@chromium.org>2015-11-05 23:01:20 +0000
commit6c06ff83d6f64dae290e0690563d099c254bb96b (patch)
treef8b44b0f5ac78da2d901b09d93b4d224f2827149 /ppapi/tests/test_printing.h
parentb6cecdd86db6d3bf716e6af83f20bb1d628423aa (diff)
downloadchromium_src-6c06ff83d6f64dae290e0690563d099c254bb96b.zip
chromium_src-6c06ff83d6f64dae290e0690563d099c254bb96b.tar.gz
chromium_src-6c06ff83d6f64dae290e0690563d099c254bb96b.tar.bz2
Separated CSSValueID calls to to CSSPrimitiveValue::create
Until now, calls to CSSPrimitiveValue::create<CSSValueID> compiled correctly since a constructor exists that takes a CSSValueID. However, create() should be reserved for custom constructors defined for platform enums, etc. Also, as pre-work to splitting out CSSValueID, calls to these two functions need to be distinct. This change adds an assert to create() so that calling it with a CSSValueID throws a compile error, and fixes all callsites that break with this change. Also removes the custom constructors for int, short, float etc, since these shouldn't exist. Callers should explicitly specify the number type to prevent confusion (there are only 3 callsites that violate this and they are all in one place). BUG=523893 Review URL: https://codereview.chromium.org/1409933010 Cr-Commit-Position: refs/heads/master@{#358162}
Diffstat (limited to 'ppapi/tests/test_printing.h')
0 files changed, 0 insertions, 0 deletions