diff options
author | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-03-10 07:49:10 +0000 |
---|---|---|
committer | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-03-10 07:49:10 +0000 |
commit | f237c0faa440ad898c234da4b999ced61cc17b88 (patch) | |
tree | 733bc7f3fe8a48aea070d0c1a1e1c757b917a179 /ppapi/tests/test_view.cc | |
parent | 77671dd7696af0536b4f3a4f0d2e21e13b723c6a (diff) | |
download | chromium_src-f237c0faa440ad898c234da4b999ced61cc17b88.zip chromium_src-f237c0faa440ad898c234da4b999ced61cc17b88.tar.gz chromium_src-f237c0faa440ad898c234da4b999ced61cc17b88.tar.bz2 |
Switch PPAPITests to run in browser_tests instead of ui_tests. The former is sharded and so tests run in parallel. Before this they were taking 17 minutes on the trybot. Now they take about a minute.
Another benefit is we can replace the sleeps with messages, so hopefully this makes the test faster/less flakier.
BUG=115595
Review URL: https://chromiumcodereview.appspot.com/9646027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126019 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi/tests/test_view.cc')
-rw-r--r-- | ppapi/tests/test_view.cc | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/ppapi/tests/test_view.cc b/ppapi/tests/test_view.cc index 3889285..6a8e748 100644 --- a/ppapi/tests/test_view.cc +++ b/ppapi/tests/test_view.cc @@ -93,9 +93,8 @@ std::string TestView::TestPageHideShow() { ASSERT_FALSE(page_visibility_log_.empty());
ASSERT_TRUE(page_visibility_log_[0]);
- // Now that we're alive, set a cookie so the UI test knows it can change our
- // visibility.
- instance_->SetCookie("TestPageHideShow:Created", "TRUE");
+ // Now that we're alive, tell the test knows it can change our visibility.
+ instance_->ReportProgress("TestPageHideShow:Created");
// Wait until we get a hide event, being careful to handle spurious
// notifications of ViewChanged.
@@ -116,8 +115,8 @@ std::string TestView::TestPageHideShow() { "tab, waiting 2 more secs, and closing the new tab.";
}
- // Set a cookie so the UI test knows it can show us again.
- instance_->SetCookie("TestPageHideShow:Hidden", "TRUE");
+ // Tell the test so it can show us again.
+ instance_->ReportProgress("TestPageHideShow:Hidden");
// Wait until we get a show event.
begin_time = pp::Module::Get()->core()->GetTime();
|