diff options
| author | mseaborn@chromium.org <mseaborn@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-08-31 20:12:26 +0000 |
|---|---|---|
| committer | mseaborn@chromium.org <mseaborn@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-08-31 20:12:26 +0000 |
| commit | 97acc76ad51dc0da925951486f88642b97aac5a2 (patch) | |
| tree | 0bea579c7587088bfdfe9c6ba9a63a1d4130407f /ppapi | |
| parent | a2583866097dc99ff237c88c5ab97d90a97a1bba (diff) | |
| download | chromium_src-97acc76ad51dc0da925951486f88642b97aac5a2.zip chromium_src-97acc76ad51dc0da925951486f88642b97aac5a2.tar.gz chromium_src-97acc76ad51dc0da925951486f88642b97aac5a2.tar.bz2 | |
NaCl: Fully re-enable Breakpad tests on 32-bit Windows
Remove the hack for ignoring some of the Breakpad test failures. This
hack outputs a warning, but I'm not seeing this warning being produced
on the 32-bit Windows Buildbot, so this failure mode seems to have
gone away. Perhaps the failures were caused by a real crash bug in
Chromium which has since been fixed.
BUG=143413
TEST=nacl_integration
Review URL: https://chromiumcodereview.appspot.com/10907022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154491 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi')
| -rwxr-xr-x | ppapi/native_client/tests/breakpad_crash_test/crash_dump_tester.py | 14 |
1 files changed, 0 insertions, 14 deletions
diff --git a/ppapi/native_client/tests/breakpad_crash_test/crash_dump_tester.py b/ppapi/native_client/tests/breakpad_crash_test/crash_dump_tester.py index 0e2e30c..f0ce0e9 100755 --- a/ppapi/native_client/tests/breakpad_crash_test/crash_dump_tester.py +++ b/ppapi/native_client/tests/breakpad_crash_test/crash_dump_tester.py @@ -152,20 +152,6 @@ def Main(): # containing an expected function name can be extracted from the # crash dump. - # This is a temporary hack because on 32-bit Windows we are getting - # an unexpected extra crash dump (without a corresponding .txt file, - # so we can't tell what process is producing it). - # TODO(mseaborn): Debug this problem and remove this hack. - # See http://code.google.com/p/chromium/issues/detail?id=143413 - if (sys.platform == 'win32' and - not options.win64 and - len(dmp_files) == options.expected_crash_dumps + 1): - sys.stdout.write('@@@STEP_WARNINGS@@@\n') - sys.stdout.write('@@@STEP_TEXT@Received an excess Breakpad crash dump@@@\n') - sys.stdout.write('crash_dump_tester: Ignoring failure caused by ' - 'excess crash dump on 32-bit Windows\n') - failed = False - if failed: sys.stdout.write('crash_dump_tester: FAILED\n') result = 1 |