summaryrefslogtreecommitdiffstats
path: root/ppapi
diff options
context:
space:
mode:
authorpolina@google.com <polina@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2012-01-30 23:17:40 +0000
committerpolina@google.com <polina@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2012-01-30 23:17:40 +0000
commitb6a9ecc4130a128f3cf148745bd68d74a9d9ca70 (patch)
treee93705828ec8aee75426b1d13c07295eb492a44d /ppapi
parent16958d88f010642e90a5bbf74eeeb7b5bc1fea5d (diff)
downloadchromium_src-b6a9ecc4130a128f3cf148745bd68d74a9d9ca70.zip
chromium_src-b6a9ecc4130a128f3cf148745bd68d74a9d9ca70.tar.gz
chromium_src-b6a9ecc4130a128f3cf148745bd68d74a9d9ca70.tar.bz2
ppapi_tests: Remove the source of flakiness from out-of-process FlashFullscreen test. No longer mark the test as
flaky. TEST=ui_tests BUG=108471 Review URL: https://chromiumcodereview.appspot.com/9133024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119760 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi')
-rw-r--r--ppapi/tests/test_flash_fullscreen.cc14
1 files changed, 9 insertions, 5 deletions
diff --git a/ppapi/tests/test_flash_fullscreen.cc b/ppapi/tests/test_flash_fullscreen.cc
index 0d7163b..b724fef 100644
--- a/ppapi/tests/test_flash_fullscreen.cc
+++ b/ppapi/tests/test_flash_fullscreen.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -76,10 +76,14 @@ std::string TestFlashFullscreen::TestNormalToFullscreenToNormal() {
pp::Graphics2D graphics2d_fullscreen(instance_, pp::Size(10, 10), false);
if (graphics2d_fullscreen.is_null())
return "Failed to create graphics2d_fullscreen";
- if (instance_->BindGraphics(graphics2d_fullscreen))
- return ReportError("BindGraphics() in fullscreen transition", true);
- if (screen_mode_.IsFullscreen())
- return ReportError("IsFullscreen() in fullscreen transtion", true);
+ // The out-of-process proxy is asynchronous, so testing for the following
+ // conditions is flaky and can only be done reliably in-process.
+ if (!testing_interface_->IsOutOfProcess()) {
+ if (instance_->BindGraphics(graphics2d_fullscreen))
+ return ReportError("BindGraphics() in fullscreen transition", true);
+ if (screen_mode_.IsFullscreen())
+ return ReportError("IsFullscreen() in fullscreen transtion", true);
+ }
// DidChangeView() will call the callback once in fullscreen mode.
fullscreen_callback_.WaitForResult();