summaryrefslogtreecommitdiffstats
path: root/printing/printing_context_mac.h
diff options
context:
space:
mode:
authordcheng <dcheng@chromium.org>2014-10-21 17:04:34 -0700
committerCommit bot <commit-bot@chromium.org>2014-10-22 00:05:25 +0000
commitd5a0f18a2795cf4cf5dc1b4f1354e6aca3a7cc6e (patch)
tree6ee673b3a09b0c4f8f01dc12661b9e528886a328 /printing/printing_context_mac.h
parent1ce56f7c60db7b27e0d13cdd45aa2ed1e74dc7ec (diff)
downloadchromium_src-d5a0f18a2795cf4cf5dc1b4f1354e6aca3a7cc6e.zip
chromium_src-d5a0f18a2795cf4cf5dc1b4f1354e6aca3a7cc6e.tar.gz
chromium_src-d5a0f18a2795cf4cf5dc1b4f1354e6aca3a7cc6e.tar.bz2
Standardize usage of virtual/override/final in printing/
The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=vitalybuka@chromium.org Review URL: https://codereview.chromium.org/668073002 Cr-Commit-Position: refs/heads/master@{#300573}
Diffstat (limited to 'printing/printing_context_mac.h')
-rw-r--r--printing/printing_context_mac.h33
1 files changed, 16 insertions, 17 deletions
diff --git a/printing/printing_context_mac.h b/printing/printing_context_mac.h
index 3701597..561b25d 100644
--- a/printing/printing_context_mac.h
+++ b/printing/printing_context_mac.h
@@ -22,25 +22,24 @@ namespace printing {
class PRINTING_EXPORT PrintingContextMac : public PrintingContext {
public:
explicit PrintingContextMac(Delegate* delegate);
- virtual ~PrintingContextMac();
+ ~PrintingContextMac() override;
// PrintingContext implementation.
- virtual void AskUserForSettings(
- int max_pages,
- bool has_selection,
- const PrintSettingsCallback& callback) override;
- virtual Result UseDefaultSettings() override;
- virtual gfx::Size GetPdfPaperSizeDeviceUnits() override;
- virtual Result UpdatePrinterSettings(bool external_preview,
- bool show_system_dialog) override;
- virtual Result InitWithSettings(const PrintSettings& settings) override;
- virtual Result NewDocument(const base::string16& document_name) override;
- virtual Result NewPage() override;
- virtual Result PageDone() override;
- virtual Result DocumentDone() override;
- virtual void Cancel() override;
- virtual void ReleaseContext() override;
- virtual gfx::NativeDrawingContext context() const override;
+ void AskUserForSettings(int max_pages,
+ bool has_selection,
+ const PrintSettingsCallback& callback) override;
+ Result UseDefaultSettings() override;
+ gfx::Size GetPdfPaperSizeDeviceUnits() override;
+ Result UpdatePrinterSettings(bool external_preview,
+ bool show_system_dialog) override;
+ Result InitWithSettings(const PrintSettings& settings) override;
+ Result NewDocument(const base::string16& document_name) override;
+ Result NewPage() override;
+ Result PageDone() override;
+ Result DocumentDone() override;
+ void Cancel() override;
+ void ReleaseContext() override;
+ gfx::NativeDrawingContext context() const override;
private:
// Initializes PrintSettings from |print_info_|. This must be called