summaryrefslogtreecommitdiffstats
path: root/printing
diff options
context:
space:
mode:
authorthakis <thakis@chromium.org>2016-02-12 20:41:02 -0800
committerCommit bot <commit-bot@chromium.org>2016-02-13 04:41:56 +0000
commit4db8034d6f49d12f09f0210084b48671315a3675 (patch)
treeb56642a48b6be20e045df3a9c9702dcf65671a3e /printing
parent82a7a6a5936c774ff9010f3a6795e825d7165731 (diff)
downloadchromium_src-4db8034d6f49d12f09f0210084b48671315a3675.zip
chromium_src-4db8034d6f49d12f09f0210084b48671315a3675.tar.gz
chromium_src-4db8034d6f49d12f09f0210084b48671315a3675.tar.bz2
Revert of Couple of changes to shell: (patchset #1 id:1 of https://codereview.chromium.org/1691213003/ )
Reason for revert: Speculative; might've broken a few mojo-related content_browsertests (https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/45843: MojoShellTest.TestBrowserConnection (run #1): [ RUN ] MojoShellTest.TestBrowserConnection Assertion failed: impl_.get() != nullptr, file c:\b\build\slave\win_builder__dbg_\build\src\base\memory\scoped_ptr.h, line 359 MojoShellTest.TestUtilityConnection (run #1): [ RUN ] MojoShellTest.TestUtilityConnection Assertion failed: impl_.get() != nullptr, file c:\b\build\slave\win_builder__dbg_\build\src\base\memory\scoped_ptr.h, line 359) Original issue's description: > Couple of changes to shell: > > . Adds PackageManager::BuildinAppLoaded(). This is needed else we > don't attempt to read the manifest for apps loaded via > ApplicationLoaders. > . Replaces CHECK in PackageManagerImpl::DeserializeApplication with > early out. The CHECK is problematic in the case of apps referring to > other apps. > . Adds type to mojo_application_manifest as executables need to be > handled differently. > > BUG=581539 > TEST=none > R=ben@chromium.org TBR=ben@chromium.org,sky@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=581539 Review URL: https://codereview.chromium.org/1701483002 Cr-Commit-Position: refs/heads/master@{#375345}
Diffstat (limited to 'printing')
0 files changed, 0 insertions, 0 deletions