diff options
| author | kmadhusu@chromium.org <kmadhusu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-28 22:09:37 +0000 |
|---|---|---|
| committer | kmadhusu@chromium.org <kmadhusu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-28 22:09:37 +0000 |
| commit | afbdbf11a0beb96ac10459e5748db0f5abc41ef5 (patch) | |
| tree | 505f31d137c2adffe995c6611defb17393a06bad /printing | |
| parent | e247dc15bdfc9461b71e3b9e1d91995d2b1a0640 (diff) | |
| download | chromium_src-afbdbf11a0beb96ac10459e5748db0f5abc41ef5.zip chromium_src-afbdbf11a0beb96ac10459e5748db0f5abc41ef5.tar.gz chromium_src-afbdbf11a0beb96ac10459e5748db0f5abc41ef5.tar.bz2 | |
PrintPreview: Remove NOTIMPLEMENTED() function call in PrintingContextWin::UpdatePrintSettings().
In r79315, Code changes were made to pass the default options on first preview generation ie., UpdatePrintSettings() function is called while generating the print preview. Because of the NOTIMPLEMENTED() function call in that function, we are seeing a crash in debug builds while generating print preview.
BUG=77473
TEST= none
Review URL: http://codereview.chromium.org/6727032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79622 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'printing')
| -rw-r--r-- | printing/printing_context_win.cc | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/printing/printing_context_win.cc b/printing/printing_context_win.cc index 23832ad..1b62c44 100644 --- a/printing/printing_context_win.cc +++ b/printing/printing_context_win.cc @@ -213,11 +213,12 @@ PrintingContext::Result PrintingContextWin::UpdatePrintSettings( const DictionaryValue& job_settings, const PageRanges& ranges) { DCHECK(!in_print_job_); - settings_.ranges = ranges; + // TODO(kmadhusu): Update other print settings such as number of copies, + // collate, duplex printing, job title, etc., - NOTIMPLEMENTED(); + settings_.ranges = ranges; - return FAILED; + return OK; } PrintingContext::Result PrintingContextWin::InitWithSettings( |