summaryrefslogtreecommitdiffstats
path: root/printing
diff options
context:
space:
mode:
authorkmadhusu@chromium.org <kmadhusu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-03-25 19:46:21 +0000
committerkmadhusu@chromium.org <kmadhusu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-03-25 19:46:21 +0000
commitf242acfd15c30ef104f3a067688c46828d03ae2c (patch)
treed0b49dafee29049dcf95d7805cf0185ec2ca8726 /printing
parentd58a93ae3d8cf81174d4dcbd24fe271659e35dd6 (diff)
downloadchromium_src-f242acfd15c30ef104f3a067688c46828d03ae2c.zip
chromium_src-f242acfd15c30ef104f3a067688c46828d03ae2c.tar.gz
chromium_src-f242acfd15c30ef104f3a067688c46828d03ae2c.tar.bz2
PrintPreview: Remove NOTIMPLEMENTED() function call in PrintingContextCairo::UpdatePrintSettings().
In r79315, Code changes were made to pass the default options on first preview generation ie., UpdatePrintSettings() function is called while generating the print preview. Because of the NOTIMPLEMENTED() function call in that function, we are seeing a crash in debug builds while generating print preview. BUG=none TEST= Enable print preview on linux. Press Ctrl+p on any webpage. Print Preview is generated successfully. Review URL: http://codereview.chromium.org/6747003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79441 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'printing')
-rw-r--r--printing/printing_context_cairo.cc5
1 files changed, 3 insertions, 2 deletions
diff --git a/printing/printing_context_cairo.cc b/printing/printing_context_cairo.cc
index 75dac3e..5687fff 100644
--- a/printing/printing_context_cairo.cc
+++ b/printing/printing_context_cairo.cc
@@ -154,9 +154,10 @@ PrintingContext::Result PrintingContextCairo::UpdatePrintSettings(
settings_.ranges = ranges;
- NOTIMPLEMENTED();
+ // TODO(kmadhusu): Update other print settings such as number of copies,
+ // collate, duplex printing, etc.,
- return FAILED;
+ return OK;
}
PrintingContext::Result PrintingContextCairo::InitWithSettings(