diff options
| author | alexeypa@chromium.org <alexeypa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-28 16:33:24 +0000 |
|---|---|---|
| committer | alexeypa@chromium.org <alexeypa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-28 16:33:24 +0000 |
| commit | 89331d3564a0dffb3fc2f6c13b3734748f01a1b3 (patch) | |
| tree | 3c7a9fa1d29a8df128d1beb6b2b63c9073b83960 /remoting/base | |
| parent | a62dfa35936f2259ff0eaf9b7b817228814c349d (diff) | |
| download | chromium_src-89331d3564a0dffb3fc2f6c13b3734748f01a1b3.zip chromium_src-89331d3564a0dffb3fc2f6c13b3734748f01a1b3.tar.gz chromium_src-89331d3564a0dffb3fc2f6c13b3734748f01a1b3.tar.bz2 | |
Do not include memory referenced by locals and other stack memory to the dump. This memory is valuable during debugging but it increases size of minidumps beyond the accepted limit. The result is the dumps are not processed at all and we don't get any information.
BUG=162914
Review URL: https://chromiumcodereview.appspot.com/11299213
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169963 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'remoting/base')
| -rw-r--r-- | remoting/base/breakpad_win.cc | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/remoting/base/breakpad_win.cc b/remoting/base/breakpad_win.cc index ef16a24..d083ceed 100644 --- a/remoting/base/breakpad_win.cc +++ b/remoting/base/breakpad_win.cc @@ -112,12 +112,10 @@ BreakpadWin::BreakpadWin() : handling_exception_(0) { if (length == 0) return; - // Minidump with stacks, PEB, TEB, unloaded module list and memory referenced - // from stack. + // Minidump with stacks, PEB, TEBs and unloaded module list. MINIDUMP_TYPE dump_type = static_cast<MINIDUMP_TYPE>( MiniDumpWithProcessThreadData | - MiniDumpWithUnloadedModules | - MiniDumpWithIndirectlyReferencedMemory); + MiniDumpWithUnloadedModules); breakpad_.reset( new google_breakpad::ExceptionHandler( temp_directory, &OnExceptionCallback, NULL, NULL, |