RefCounted types should not have public destructors, delegate cleanup

For Delegate/Observer-type classes that specify an
interface but do not have any particular lifetime
requirements, make their destructors protected. This is to
allow their interfaces to be implemented safely by
RefCounted types. With public destructors, it's possible to
do "scoped_ptr<Delegate> foo", and then assign a
RefCountedDelegateImpl, which would lead to a double free.

As none of these Delegates actually need public destructors
(ownership of the Delegate* is not transferred during a
function call / class constructor), mark the destructors
protected so that it becomes a compile warning to try to
delete them via the Delegate*.

BUG=123295
TEST=it compiles


Review URL: https://chromiumcodereview.appspot.com/10383262

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144086 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 4 insertions, 3 deletions

diff --git a/remoting/client/frame_consumer.h b/remoting/client/frame_consumer.h
index ce852b4..22701f4 100644
--- a/remoting/client/frame_consumer.h
+++ b/remoting/client/frame_consumer.h
@@ -17,9 +17,6 @@ namespace remoting {
 
 class FrameConsumer {
  public:
-  FrameConsumer() {}
-  virtual ~FrameConsumer() {}
-
   // Accepts a buffer to be painted to the screen. The buffer's dimensions and
   // relative position within the frame are specified by |clip_area|. Only
   // pixels falling within |region| and the current clipping area are painted.
@@ -41,6 +38,10 @@ class FrameConsumer {
   // Set the dimension of the entire host screen.
   virtual void SetSourceSize(const SkISize& source_size) = 0;
 
+ protected:
+  FrameConsumer() {}
+  virtual ~FrameConsumer() {}
+
  private:
   DISALLOW_COPY_AND_ASSIGN(FrameConsumer);
 };