diff options
| author | benjhayden@chromium.org <benjhayden@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-07-26 17:26:40 +0000 |
|---|---|---|
| committer | benjhayden@chromium.org <benjhayden@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-07-26 17:26:40 +0000 |
| commit | 6a1a59a1fe996029e2dda0dc8592257f9fa0408b (patch) | |
| tree | 95f08dbf1056e60357f8a347e30d9e083201cfb7 /remoting/host/heartbeat_sender.cc | |
| parent | f8fb5025580e36fd9ebe9f6e09ca5802021a939d (diff) | |
| download | chromium_src-6a1a59a1fe996029e2dda0dc8592257f9fa0408b.zip chromium_src-6a1a59a1fe996029e2dda0dc8592257f9fa0408b.tar.gz chromium_src-6a1a59a1fe996029e2dda0dc8592257f9fa0408b.tar.bz2 | |
DownloadManager::Observer::OnDownloadCreated
Currently, it is fired when the DownloadItem is created, not when it has its filename, not when it's persisted. Listeners should observe the item for those kinds of state changes.
Those Observers that care about the filename (any of the filenames) should check whether it's empty() before using it. The DownloadItem[Impl] will UpdateObservers when the filename changes.
OnDownloadCreated is not fired for SavePackage downloads. It will be fired when we are comfortable with the user interacting with them, which might not happen until after the SavePackage integration.
ExtensionDownloadsEventRouter filters out temporary downloads, which are downloads whose DownloadCreateInfo.save_info.file_path is not empty(). GData also calls SetIsTemporary after OnDownloadCreated is fired, but only for SavePackage downloads, so EDER is safe there.
Review URL: https://chromiumcodereview.appspot.com/10735089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148576 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'remoting/host/heartbeat_sender.cc')
0 files changed, 0 insertions, 0 deletions