summaryrefslogtreecommitdiffstats
path: root/remoting/host/setup/daemon_controller_linux.cc
diff options
context:
space:
mode:
authordcheng@chromium.org <dcheng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-04-09 05:45:17 +0000
committerdcheng@chromium.org <dcheng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-04-09 05:45:17 +0000
commite59558b78e8c6a1b0bd916a724724b638c3c91b6 (patch)
tree712268a7e9e1cd552f309d89641b2bed5ad06322 /remoting/host/setup/daemon_controller_linux.cc
parent31fcd34da3797bc49160620ef8c94a38652c0587 (diff)
downloadchromium_src-e59558b78e8c6a1b0bd916a724724b638c3c91b6.zip
chromium_src-e59558b78e8c6a1b0bd916a724724b638c3c91b6.tar.gz
chromium_src-e59558b78e8c6a1b0bd916a724724b638c3c91b6.tar.bz2
Rewrite std::string("") to std::string(), Linux edition.
This patch was generated by running the empty_string clang tool across the Chromium Linux compilation database. Implicitly or explicitly constructing std::string() with a "" argument is inefficient as the caller needs to emit extra instructions to pass an argument, and the constructor needlessly copies a byte into internal storage. Rewriting these instances to simply call the default constructor appears to save ~14-18 kilobytes on an optimized release build. BUG=none Review URL: https://codereview.chromium.org/13145003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193020 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'remoting/host/setup/daemon_controller_linux.cc')
-rw-r--r--remoting/host/setup/daemon_controller_linux.cc6
1 files changed, 3 insertions, 3 deletions
diff --git a/remoting/host/setup/daemon_controller_linux.cc b/remoting/host/setup/daemon_controller_linux.cc
index f5076d4..216572f 100644
--- a/remoting/host/setup/daemon_controller_linux.cc
+++ b/remoting/host/setup/daemon_controller_linux.cc
@@ -318,7 +318,7 @@ void DaemonControllerLinux::DoGetVersion(
const GetVersionCallback& done_callback) {
base::FilePath script_path;
if (!GetScriptPath(&script_path)) {
- done_callback.Run("");
+ done_callback.Run(std::string());
return;
}
CommandLine command_line(script_path);
@@ -331,14 +331,14 @@ void DaemonControllerLinux::DoGetVersion(
if (!result || exit_code != 0) {
LOG(ERROR) << "Failed to run \"" << command_line.GetCommandLineString()
<< "\". Exit code: " << exit_code;
- done_callback.Run("");
+ done_callback.Run(std::string());
return;
}
TrimWhitespaceASCII(version, TRIM_ALL, &version);
if (!ContainsOnlyChars(version, "0123456789.")) {
LOG(ERROR) << "Received invalid host version number: " << version;
- done_callback.Run("");
+ done_callback.Run(std::string());
return;
}