UAC and pin confirmation dialogs are not on foreground when updating pin #

In this change we elevate the me2me native messaging host before calling into the daemon controller for the tasks that requires elevation. The daemon controller still depends on the com component for those tasks but the elevation is now done in the me2me native messaging host itself.

In followup CLs I will remove the elevated daemon controller com component and move its implementation to DaemonControllerDelegateWin.

Note that the pin confirmation dialog is removed with this CL. This change has been approved by the chrome security team.

BUG=447246

Review URL: https://codereview.chromium.org/880133003

Cr-Commit-Position: refs/heads/master@{#313545}

1 files changed, 18 insertions, 0 deletions

diff --git a/remoting/host/setup/me2me_native_messaging_host.cc b/remoting/host/setup/me2me_native_messaging_host.cc
index 37bedac..e3480b1 100644
--- a/remoting/host/setup/me2me_native_messaging_host.cc
+++ b/remoting/host/setup/me2me_native_messaging_host.cc
@@ -280,6 +280,12 @@ void Me2MeNativeMessagingHost::ProcessUpdateDaemonConfig(
     scoped_ptr<base::DictionaryValue> response) {
   DCHECK(thread_checker_.CalledOnValidThread());
 
+  if (needs_elevation_) {
+    if (!DelegateToElevatedHost(message.Pass()))
+      SendAsyncResult(response.Pass(), DaemonController::RESULT_FAILED);
+    return;
+  }
+
   scoped_ptr<base::DictionaryValue> config_dict =
       ConfigDictionaryFromMessage(message.Pass());
   if (!config_dict) {
@@ -333,6 +339,12 @@ void Me2MeNativeMessagingHost::ProcessStartDaemon(
     scoped_ptr<base::DictionaryValue> response) {
   DCHECK(thread_checker_.CalledOnValidThread());
 
+  if (needs_elevation_) {
+    if (!DelegateToElevatedHost(message.Pass()))
+      SendAsyncResult(response.Pass(), DaemonController::RESULT_FAILED);
+    return;
+  }
+
   bool consent;
   if (!message->GetBoolean("consent", &consent)) {
     LOG(ERROR) << "'consent' not found.";
@@ -358,6 +370,12 @@ void Me2MeNativeMessagingHost::ProcessStopDaemon(
     scoped_ptr<base::DictionaryValue> response) {
   DCHECK(thread_checker_.CalledOnValidThread());
 
+  if (needs_elevation_) {
+    if (!DelegateToElevatedHost(message.Pass()))
+      SendAsyncResult(response.Pass(), DaemonController::RESULT_FAILED);
+    return;
+  }
+
   daemon_controller_->Stop(
       base::Bind(&Me2MeNativeMessagingHost::SendAsyncResult, weak_ptr_,
                  base::Passed(&response)));