summaryrefslogtreecommitdiffstats
path: root/remoting/host
diff options
context:
space:
mode:
authorlambroslambrou <lambroslambrou@chromium.org>2016-03-03 11:14:19 -0800
committerCommit bot <commit-bot@chromium.org>2016-03-03 19:15:46 +0000
commit067afe39375191d6cb2e56ff24bd093176a95a62 (patch)
tree191ae9f829f520035142cb49f632acc685eff7f2 /remoting/host
parent42eb5e2ced5dd13c85b2e5bee8a2d67463dea53d (diff)
downloadchromium_src-067afe39375191d6cb2e56ff24bd093176a95a62.zip
chromium_src-067afe39375191d6cb2e56ff24bd093176a95a62.tar.gz
chromium_src-067afe39375191d6cb2e56ff24bd093176a95a62.tar.bz2
[remoting host] Add comments to explain some DCHECKs
Some DCHECKS relating to ThirdPartyAuthConfig were non-obvious, so this adds some clarifying comments. Review URL: https://codereview.chromium.org/1760773002 Cr-Commit-Position: refs/heads/master@{#379052}
Diffstat (limited to 'remoting/host')
-rw-r--r--remoting/host/remoting_me2me_host.cc5
1 files changed, 5 insertions, 0 deletions
diff --git a/remoting/host/remoting_me2me_host.cc b/remoting/host/remoting_me2me_host.cc
index 180c15b..c44740d 100644
--- a/remoting/host/remoting_me2me_host.cc
+++ b/remoting/host/remoting_me2me_host.cc
@@ -801,6 +801,8 @@ void HostProcess::CreateAuthenticatorFactory() {
host_->set_pairing_registry(pairing_registry);
} else {
+ // ThirdPartyAuthConfig::Parse() leaves the config in a valid state, so
+ // these URLs are both valid.
DCHECK(third_party_auth_config_.token_url.is_valid());
DCHECK(third_party_auth_config_.token_validation_url.is_valid());
@@ -1372,6 +1374,9 @@ bool HostProcess::OnHostTokenUrlPolicyUpdate(base::DictionaryValue* policies) {
return true;
case ThirdPartyAuthConfig::InvalidPolicy:
default:
+ // Unreachable, because PolicyWatcher::OnPolicyUpdated() enforces that
+ // the policy is well-formed (including checks specific to
+ // ThirdPartyAuthConfig), before notifying of policy updates.
NOTREACHED();
return false;
}