Clean-up inline members of nested classes (remoting/)

Due to a bug, the Clang-plugin style checker failed to warn about
inline constructors, destructors, non-empty virtual methods, etc.
for nested classes.

The plugin has been fixed, and this patch is part of a clean-up of all
the code that now causes the plugin to issue errors.

BUG=139346


Review URL: https://chromiumcodereview.appspot.com/10855076

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150913 0039d316-1c4b-4281-b951-d872f2087c98

6 files changed, 21 insertions, 0 deletions

diff --git a/remoting/host/heartbeat_sender.cc b/remoting/host/heartbeat_sender.cc
index 8fac219..ee63ffd5 100644
--- a/remoting/host/heartbeat_sender.cc
+++ b/remoting/host/heartbeat_sender.cc
@@ -88,6 +88,11 @@ void HeartbeatSender::OnSignalStrategyStateChange(SignalStrategy::State state) {
   }
 }
 
+bool HeartbeatSender::OnSignalStrategyIncomingStanza(
+    const buzz::XmlElement* stanza) {
+  return false;
+}
+
 void HeartbeatSender::SendStanza() {
   DoSendStanza();
   // Make sure we don't send another heartbeat before the heartbeat interval
diff --git a/remoting/host/heartbeat_sender.h b/remoting/host/heartbeat_sender.h
index daa7ed8..2fb2dae 100644
--- a/remoting/host/heartbeat_sender.h
+++ b/remoting/host/heartbeat_sender.h
@@ -98,6 +98,8 @@ class HeartbeatSender : public SignalStrategy::Listener {
   // SignalStrategy::Listener interface.
   virtual void OnSignalStrategyStateChange(
       SignalStrategy::State state) OVERRIDE;
+  virtual bool OnSignalStrategyIncomingStanza(
+      const buzz::XmlElement* stanza) OVERRIDE;
 
  private:
   FRIEND_TEST_ALL_PREFIXES(HeartbeatSenderTest, DoSendStanza);
diff --git a/remoting/host/log_to_server.cc b/remoting/host/log_to_server.cc
index c93bbd9..a184de0 100644
--- a/remoting/host/log_to_server.cc
+++ b/remoting/host/log_to_server.cc
@@ -66,6 +66,11 @@ void LogToServer::OnSignalStrategyStateChange(SignalStrategy::State state) {
   }
 }
 
+bool LogToServer::OnSignalStrategyIncomingStanza(
+    const buzz::XmlElement* stanza) {
+  return false;
+}
+
 void LogToServer::OnClientConnected(const std::string& jid) {
   DCHECK(CalledOnValidThread());
   LogSessionStateChange(jid, true);
diff --git a/remoting/host/log_to_server.h b/remoting/host/log_to_server.h
index 765239645..c1f844a 100644
--- a/remoting/host/log_to_server.h
+++ b/remoting/host/log_to_server.h
@@ -49,6 +49,8 @@ class LogToServer : public base::NonThreadSafe,
   // SignalStrategy::Listener interface.
   virtual void OnSignalStrategyStateChange(
       SignalStrategy::State state) OVERRIDE;
+  virtual bool OnSignalStrategyIncomingStanza(
+      const buzz::XmlElement* stanza) OVERRIDE;
 
   // HostStatusObserver interface.
   virtual void OnClientConnected(const std::string& jid) OVERRIDE;
diff --git a/remoting/host/signaling_connector.cc b/remoting/host/signaling_connector.cc
index e93c398..9e95219 100644
--- a/remoting/host/signaling_connector.cc
+++ b/remoting/host/signaling_connector.cc
@@ -80,6 +80,11 @@ void SignalingConnector::OnSignalStrategyStateChange(
   }
 }
 
+bool SignalingConnector::OnSignalStrategyIncomingStanza(
+    const buzz::XmlElement* stanza) {
+  return false;
+}
+
 void SignalingConnector::OnIPAddressChanged() {
   DCHECK(CalledOnValidThread());
   LOG(INFO) << "IP address has changed.";
diff --git a/remoting/host/signaling_connector.h b/remoting/host/signaling_connector.h
index 6cad617..f1466b7 100644
--- a/remoting/host/signaling_connector.h
+++ b/remoting/host/signaling_connector.h
@@ -63,6 +63,8 @@ class SignalingConnector
   // SignalStrategy::Listener interface.
   virtual void OnSignalStrategyStateChange(
       SignalStrategy::State state) OVERRIDE;
+  virtual bool OnSignalStrategyIncomingStanza(
+      const buzz::XmlElement* stanza) OVERRIDE;
 
   // NetworkChangeNotifier::IPAddressObserver interface.
   virtual void OnIPAddressChanged() OVERRIDE;