diff options
| author | lukasza <lukasza@chromium.org> | 2015-01-23 18:09:19 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-01-24 02:10:03 +0000 |
| commit | 56dd1e9481b2a7cdb8fd2067046e452bb765ffa4 (patch) | |
| tree | 0cef2985ee7b6ae6cfc63bf7aab064a130e39810 /remoting/remoting_host_srcs.gypi | |
| parent | d1caf97fe8db47e5c76043bccbf4dd4a42265831 (diff) | |
| download | chromium_src-56dd1e9481b2a7cdb8fd2067046e452bb765ffa4.zip chromium_src-56dd1e9481b2a7cdb8fd2067046e452bb765ffa4.tar.gz chromium_src-56dd1e9481b2a7cdb8fd2067046e452bb765ffa4.tar.bz2 | |
Removing FakePolicyWatcher and introducing FakeAsyncPolicyLoader.
Removal of FakePolicyWatcher means that PolicyServiceWatcher is now the only
class derived from PolicyWatcher. A next check-in should merge PolicyWatcher
and PolicyServiceWatcher into a single class.
Testing via FakeAsyncPolicyLoader rather than FakePolicyWatcher means that
tests cover more of PolicyServiceWatcher code.
I chose to introduce FakeAsyncPolicyLoader, rather than going via an already
existing MockConfigurationPolicyProvier, because 1) this way I can cover more
of PolicyServiceWatcher code and 2) this simplifies the test code (by a) keeping
PolicySchema manipulation within the product code and b) not requiring mocking
of IsInitializationComplete and c) being able to directly call into unmodified
CreateFromPolicyLoader method in the product code).
BUG=368321
Review URL: https://codereview.chromium.org/858303003
Cr-Commit-Position: refs/heads/master@{#312994}
Diffstat (limited to 'remoting/remoting_host_srcs.gypi')
| -rw-r--r-- | remoting/remoting_host_srcs.gypi | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/remoting/remoting_host_srcs.gypi b/remoting/remoting_host_srcs.gypi index c3a7a8b..4d5d628 100644 --- a/remoting/remoting_host_srcs.gypi +++ b/remoting/remoting_host_srcs.gypi @@ -190,6 +190,7 @@ 'host/policy_hack/policy_watcher.cc', 'host/policy_hack/policy_watcher.h', 'host/policy_hack/policy_service_watcher.cc', + 'host/policy_hack/policy_service_watcher.h', 'host/register_support_host_request.cc', 'host/register_support_host_request.h', 'host/remote_input_filter.cc', |