diff options
| author | chrishall <chrishall@chromium.org> | 2016-03-09 22:47:20 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-03-10 06:49:39 +0000 |
| commit | f1dcaac3801ed8d0a8abe62f1496e61fbaf639a7 (patch) | |
| tree | f868b3d5d0d8fd4cd747e1739734f3d53fbc198d /remoting/remoting_test.gypi | |
| parent | 3a46edeeb8cc6b47bfd3210042964324eaf28c07 (diff) | |
| download | chromium_src-f1dcaac3801ed8d0a8abe62f1496e61fbaf639a7.zip chromium_src-f1dcaac3801ed8d0a8abe62f1496e61fbaf639a7.tar.gz chromium_src-f1dcaac3801ed8d0a8abe62f1496e61fbaf639a7.tar.bz2 | |
Revert of Implement authenticator based on SPAKE2 implementation in boringssl. (patchset #5 id:140001 of https://codereview.chromium.org/1759313002/ )
Reason for revert:
This patch added 2 more tests which are now failing on Linux MSan Tests as of build #14316
https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/14316
Spake2AuthenticatorTest.InvalidSecret (run #1):
[ RUN ] Spake2AuthenticatorTest.InvalidSecret
==10538==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0x14bb0fd in ?? third_party/modp_b64/modp_b64.cc:91:20
#1 0xdcf2f6 in Base64Encode base/base64.cc:18:24
#2 0x12d6e6c in EncodeBinaryValueToXml remoting/protocol/spake2_authenticator.cc:47:3
and
Spake2AuthenticatorTest.SuccessfulAuth (run #1):
[ RUN ] Spake2AuthenticatorTest.SuccessfulAuth
==10537==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0x14bb0fd in ?? third_party/modp_b64/modp_b64.cc:91:20
#1 0xdcf2f6 in Base64Encode base/base64.cc:18:24
#2 0x12d6e6c in EncodeBinaryValueToXml remoting/protocol/spake2_authenticator.cc:47:3
Original issue's description:
> Implement authenticator based on SPAKE2 implementation in boringssl.
>
> The new authenticator uses SPAKE2 over Curve25519. It will
> be enabled in host and client in a separate CL.
>
> BUG=589698
>
> Committed: https://crrev.com/bf336334ba59ae7cd150e9cb36a9b248d174a4eb
> Cr-Commit-Position: refs/heads/master@{#379972}
TBR=kelvinp@chromium.org,davidben@chromium.org,arnarb@chromium.org,sergeyu@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=589698
Review URL: https://codereview.chromium.org/1778223003
Cr-Commit-Position: refs/heads/master@{#380365}
Diffstat (limited to 'remoting/remoting_test.gypi')
| -rw-r--r-- | remoting/remoting_test.gypi | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/remoting/remoting_test.gypi b/remoting/remoting_test.gypi index 7f6858d..5e36aa0 100644 --- a/remoting/remoting_test.gypi +++ b/remoting/remoting_test.gypi @@ -337,7 +337,6 @@ 'protocol/ppapi_module_stub.cc', 'protocol/pseudotcp_adapter_unittest.cc', 'protocol/session_config_unittest.cc', - 'protocol/spake2_authenticator_unittest.cc', 'protocol/ssl_hmac_channel_authenticator_unittest.cc', 'protocol/third_party_authenticator_unittest.cc', 'protocol/v2_authenticator_unittest.cc', |