diff options
| author | msramek <msramek@chromium.org> | 2015-08-17 02:23:25 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-08-17 09:24:02 +0000 |
| commit | 7f0dc75b563b74eeb4fa7f52edfae9650625a149 (patch) | |
| tree | fd4baeccd8479176c088a1a251ff2c555f1e7500 /remoting/remoting_webapp_files.gypi | |
| parent | c736b6bd3d9d49e43d09654a779913d048d3619d (diff) | |
| download | chromium_src-7f0dc75b563b74eeb4fa7f52edfae9650625a149.zip chromium_src-7f0dc75b563b74eeb4fa7f52edfae9650625a149.tar.gz chromium_src-7f0dc75b563b74eeb4fa7f52edfae9650625a149.tar.bz2 | |
Revert of Record the XMPP error in remoting.FormatIq. (patchset #4 id:60001 of )
Reason for revert:
Win x64 GN bot failure.
FAILED: E:/b/depot_tools/python276_bin/python.exe gyp-win-tool action-wrapper environment.x86 __remoting_webapp_build_unittest___build_toolchain_win_x64__rule.rsp
The command line is too long.
Original issue's description:
> Record the XMPP error in remoting.FormatIq.
>
> This CL
> 1. Records the XMPP error type, jingle_action and error condition
> in remoting.FormatIq.
> This error is later extracted by the ClientSession to upload along
> with session state change events.
>
> We choose to record the error in the webapp instead of the plugin to
> avoid adding new contract between the webapp and the plugin just for
> the sake of debugging, especially when we are so close to branch point.
> 2. Removes some legacy fields in the FormatIq to avoid parse errors.
> 3. Parses the error before the original jingle message. This ensures
> addition of unrecognized Jingle fields like QUIC will not break the
> error parsing.
>
> BUG=509070
>
> Committed: dba42ad74eb89a6663304462e6538ba568
> Cr-Commit-Position: refs/heads/master@{#343532}
TBR=jamiewalch@chromium.org,sergeyu@chromium.org,kelvinp@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=509070,521522
Review URL: https://codereview.chromium.org/1293103002
Cr-Commit-Position: refs/heads/master@{#343652}
Diffstat (limited to 'remoting/remoting_webapp_files.gypi')
| -rw-r--r-- | remoting/remoting_webapp_files.gypi | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/remoting/remoting_webapp_files.gypi b/remoting/remoting_webapp_files.gypi index e41ddd6..70f6819 100644 --- a/remoting/remoting_webapp_files.gypi +++ b/remoting/remoting_webapp_files.gypi @@ -93,7 +93,6 @@ 'webapp/base/js/dns_blackhole_checker_unittest.js', 'webapp/base/js/error_unittest.js', 'webapp/base/js/fallback_signal_strategy_unittest.js', - 'webapp/base/js/format_iq_unittest.js', 'webapp/base/js/identity_unittest.js', 'webapp/base/js/ipc_unittest.js', 'webapp/base/js/l10n_unittest.js', |