diff options
| author | jamiewalch <jamiewalch@chromium.org> | 2015-07-29 12:37:53 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-07-29 19:38:25 +0000 |
| commit | 8c4da59907e286fdda591559094fa0fbff7bc20d (patch) | |
| tree | 2b288394f0405f46fbf7a178bcb3dbc974f828c8 /remoting/remoting_webapp_files.gypi | |
| parent | e52cd0cb8085e23bc7b87051365e5793f4c67c87 (diff) | |
| download | chromium_src-8c4da59907e286fdda591559094fa0fbff7bc20d.zip chromium_src-8c4da59907e286fdda591559094fa0fbff7bc20d.tar.gz chromium_src-8c4da59907e286fdda591559094fa0fbff7bc20d.tar.bz2 | |
Add console errors to user feedback.
When users submit feedback, it can be useful to know what errors they have encountered recently. This CL intercepts calls to console.{error,assert}, maintaining a recent history for inclusion in feedback reports.
Intercepting these messages comes at the cost of losing the source lines for them. For developers, this can be mitigated by configuring Chrome's developer console to "blackbox" console_wrapper.js. Since we can't expect end-users to do this, we also include the log source in every message intercepted.
The CL has three (fairly cleanly separated) parts:
* Improvements to callstack helper code.
* Code to intercept console messages
* Code to activate this interception and include the results in feedback for both app remoting and CRD.
I recommend reviewing them in that order, or I can split it into three separate CLs if you prefer.
BUG=485798
Review URL: https://codereview.chromium.org/1247863004
Cr-Commit-Position: refs/heads/master@{#340952}
Diffstat (limited to 'remoting/remoting_webapp_files.gypi')
| -rw-r--r-- | remoting/remoting_webapp_files.gypi | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/remoting/remoting_webapp_files.gypi b/remoting/remoting_webapp_files.gypi index ba60573..11d0b73 100644 --- a/remoting/remoting_webapp_files.gypi +++ b/remoting/remoting_webapp_files.gypi @@ -86,8 +86,10 @@ 'webapp/base/js/base_unittest.js', 'webapp/base/js/base_event_hook_unittest.js', 'webapp/base/js/base_inherits_unittest.js', + 'webapp/base/js/callstack_unittest.js', 'webapp/base/js/client_session_unittest.js', 'webapp/base/js/client_session_factory_unittest.js', + 'webapp/base/js/console_wrapper_unittest.js', 'webapp/base/js/dns_blackhole_checker_unittest.js', 'webapp/base/js/error_unittest.js', 'webapp/base/js/fallback_signal_strategy_unittest.js', @@ -181,6 +183,8 @@ 'remoting_webapp_shared_js_core_files': [ 'webapp/base/js/application.js', 'webapp/base/js/base.js', + 'webapp/base/js/callstack.js', + 'webapp/base/js/console_wrapper.js', 'webapp/base/js/ipc.js', 'webapp/base/js/modal_dialogs.js', 'webapp/base/js/platform.js', |