diff options
| author | kelvinp <kelvinp@chromium.org> | 2015-06-05 19:56:42 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-06-06 02:58:03 +0000 |
| commit | e989257af8a63fa4e5780635259b04663247ab5b (patch) | |
| tree | d6866254e6970a7848543b6bef49b5edecc32c53 /remoting/remoting_webapp_files.gypi | |
| parent | e779456460f37de00f5b1a081d1666f03b9cccbb (diff) | |
| download | chromium_src-e989257af8a63fa4e5780635259b04663247ab5b.zip chromium_src-e989257af8a63fa4e5780635259b04663247ab5b.tar.gz chromium_src-e989257af8a63fa4e5780635259b04663247ab5b.tar.bz2 | |
Cause:
From the user agent strings in our server logs, the offending user agents are
Morzilla/5.0 (X11; CrOS x86_64 6457.107.0)
which fails to match
'CrOS ([a-zA-Z0-9]*) ([0-9.]*)'
because _ is missing in the first match group.
This CL:
1. Fixes the regular expression.
2. Unifies the duplicated platform detection logic in our logs and platform.js
3. Implements an unit test using key examples from the server logs as test cases.
BUG=495206
Review URL: https://codereview.chromium.org/1154023007
Cr-Commit-Position: refs/heads/master@{#333208}
Diffstat (limited to 'remoting/remoting_webapp_files.gypi')
| -rw-r--r-- | remoting/remoting_webapp_files.gypi | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/remoting/remoting_webapp_files.gypi b/remoting/remoting_webapp_files.gypi index ef49890..7474e67 100644 --- a/remoting/remoting_webapp_files.gypi +++ b/remoting/remoting_webapp_files.gypi @@ -89,6 +89,7 @@ 'webapp/base/js/identity_unittest.js', 'webapp/base/js/ipc_unittest.js', 'webapp/base/js/l10n_unittest.js', + 'webapp/base/js/platform_unittest.js', 'webapp/base/js/protocol_extension_manager_unittest.js', 'webapp/base/js/typecheck_unittest.js', 'webapp/base/js/viewport_unittest.js', |