diff options
| author | rch <rch@chromium.org> | 2015-05-07 21:01:07 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-05-08 04:02:28 +0000 |
| commit | b6dc7357d62efedaefaa11fb00cfc68eda649cec (patch) | |
| tree | cb0df572b24e68ce0662c44e1411b8e492ec33f9 /remoting/signaling/xmpp_signal_strategy_unittest.cc | |
| parent | 9e53d21c5715201e97c273fffd1fa8f3133c44cc (diff) | |
| download | chromium_src-b6dc7357d62efedaefaa11fb00cfc68eda649cec.zip chromium_src-b6dc7357d62efedaefaa11fb00cfc68eda649cec.tar.gz chromium_src-b6dc7357d62efedaefaa11fb00cfc68eda649cec.tar.bz2 | |
Revert of Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider (patchset #5 id:80001 of https://codereview.chromium.org/1114383003/)
Reason for revert:
Even this revised patch seems to break on iOS.
http://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/builds/26548/steps/net_unittests%20%28iPhone%205%20iOS%208.1%29/logs/stdio
WTF!?!?!?!!?
Original issue's description:
> Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider
> so that all provider subclasses can have their state verified.
>
> Committed: https://crrev.com/bce10d97d6fc5233071427cf622aaad7abde9e19
> Cr-Commit-Position: refs/heads/master@{#328154}
>
> Committed: https://crrev.com/269875cf0d23881a7ad119bae730ff54fdd4dd0b
> Cr-Commit-Position: refs/heads/master@{#328351}
>
> Committed: https://crrev.com/d833a674a5e4f3b4e47f229b3d5411a8d509c2c0
> Cr-Commit-Position: refs/heads/master@{#328909}
TBR=rtenneti@chromium.org,sergeyu@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1123383004
Cr-Commit-Position: refs/heads/master@{#328922}
Diffstat (limited to 'remoting/signaling/xmpp_signal_strategy_unittest.cc')
| -rw-r--r-- | remoting/signaling/xmpp_signal_strategy_unittest.cc | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/remoting/signaling/xmpp_signal_strategy_unittest.cc b/remoting/signaling/xmpp_signal_strategy_unittest.cc index 2193982..b4c4a53 100644 --- a/remoting/signaling/xmpp_signal_strategy_unittest.cc +++ b/remoting/signaling/xmpp_signal_strategy_unittest.cc @@ -29,14 +29,6 @@ class XmppSocketDataProvider: public net::SocketDataProvider { void Reset() override {} - bool AllReadDataConsumed() const override { - return true; - } - - bool AllWriteDataConsumed() const override { - return true; - } - void ReceiveData(const std::string& text) { socket()->OnReadComplete( net::MockRead(net::ASYNC, text.data(), text.size())); |