remoting: Add out-of-line copy ctors for complex classes.

This patch adds out of line copy constructors for classes that our
clang-plugin considers heavy. This is an effort to enable copy
constructor checks by default.

BUG=436357
R=garykac@chromium.org, dcheng@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/1736633002

Cr-Commit-Position: refs/heads/master@{#377988}

4 files changed, 7 insertions, 0 deletions

diff --git a/remoting/signaling/server_log_entry.cc b/remoting/signaling/server_log_entry.cc
index 9eda8931..080f8ea 100644
--- a/remoting/signaling/server_log_entry.cc
+++ b/remoting/signaling/server_log_entry.cc
@@ -35,6 +35,8 @@ const char kKeyCpu[] = "cpu";
 ServerLogEntry::ServerLogEntry() {
 }
 
+ServerLogEntry::ServerLogEntry(const ServerLogEntry& other) = default;
+
 ServerLogEntry::~ServerLogEntry() {
 }
 
diff --git a/remoting/signaling/server_log_entry.h b/remoting/signaling/server_log_entry.h
index f1b0ece..fbcba0f 100644
--- a/remoting/signaling/server_log_entry.h
+++ b/remoting/signaling/server_log_entry.h
@@ -28,6 +28,7 @@ class ServerLogEntry {
   };
 
   ServerLogEntry();
+  ServerLogEntry(const ServerLogEntry& other);
   ~ServerLogEntry();
 
   // Sets an arbitrary key/value entry.
diff --git a/remoting/signaling/xmpp_signal_strategy.cc b/remoting/signaling/xmpp_signal_strategy.cc
index fbc5373..10aea02 100644
--- a/remoting/signaling/xmpp_signal_strategy.cc
+++ b/remoting/signaling/xmpp_signal_strategy.cc
@@ -46,6 +46,9 @@ XmppSignalStrategy::XmppServerConfig::XmppServerConfig()
     : port(kDefaultXmppPort), use_tls(true) {
 }
 
+XmppSignalStrategy::XmppServerConfig::XmppServerConfig(
+    const XmppServerConfig& other) = default;
+
 XmppSignalStrategy::XmppServerConfig::~XmppServerConfig() {
 }
 
diff --git a/remoting/signaling/xmpp_signal_strategy.h b/remoting/signaling/xmpp_signal_strategy.h
index 8878547..4743d9f 100644
--- a/remoting/signaling/xmpp_signal_strategy.h
+++ b/remoting/signaling/xmpp_signal_strategy.h
@@ -25,6 +25,7 @@ class XmppSignalStrategy : public SignalStrategy {
   // XMPP Server configuration for XmppSignalStrategy.
   struct XmppServerConfig {
     XmppServerConfig();
+    XmppServerConfig(const XmppServerConfig& other);
     ~XmppServerConfig();
 
     std::string host;