Convert remaining StringToLowerASCII to ToLowerASCII.

Remove StringToLowerASCII. This removes the template and makes a consistent call that can take a string piece.

http_response_headers.cc in HttpResponseHeaders::RemoveHeaderLine there seemed to be a bug where it did
  std::string old_header_name_lowercase(name);
where it actually meant
  std::string old_header_name_lowercase(old_header_name);
I fixed this.

There were a number of cases where url.host() or url.scheme() was passed to ToLowerASCII. These are already guaranteed lower-case, so I removed the call.

There were a number of cases in net that did return ToLowerASCII().c_str() when the return type is a std::string, which is unnecessary and wasteful. I removed the c_str() call.

NOPRESUBMIT=true
(for touching code with wstrings)

Review URL: https://codereview.chromium.org/1282363003

Cr-Commit-Position: refs/heads/master@{#342869}

1 files changed, 2 insertions, 2 deletions

diff --git a/remoting/signaling/jid_util.cc b/remoting/signaling/jid_util.cc
index ca0c909..08e525d 100644
--- a/remoting/signaling/jid_util.cc
+++ b/remoting/signaling/jid_util.cc
@@ -12,9 +12,9 @@ std::string NormalizeJid(const std::string& jid) {
   std::string bare_jid;
   std::string resource;
   if (SplitJidResource(jid, &bare_jid, &resource)) {
-    return base::StringToLowerASCII(bare_jid) + "/" + resource;
+    return base::ToLowerASCII(bare_jid) + "/" + resource;
   }
-  return base::StringToLowerASCII(bare_jid);
+  return base::ToLowerASCII(bare_jid);
 }
 
 bool SplitJidResource(const std::string& full_jid,