diff options
author | dbeam <dbeam@chromium.org> | 2015-05-04 16:00:04 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-05-04 23:00:36 +0000 |
commit | eb1e4d1dd2511083e1d5506d1edfbdff68e133cc (patch) | |
tree | 7b8f2fdb338d07fc8cbfb2d7d37e90587b4b409e /remoting/signaling | |
parent | db926e49caab1e225a5ea52764b8b7fefbc982d2 (diff) | |
download | chromium_src-eb1e4d1dd2511083e1d5506d1edfbdff68e133cc.zip chromium_src-eb1e4d1dd2511083e1d5506d1edfbdff68e133cc.tar.gz chromium_src-eb1e4d1dd2511083e1d5506d1edfbdff68e133cc.tar.bz2 |
Revert of Revert some other possible suspects of a 0.43% size increase of setup.exe: https://build.chromium.o… (patchset #1 id:1 of https://codereview.chromium.org/1124563003/)
Reason for revert:
Broke the compile because one of these CLs is already depended on (rch@'s bce10d97d6fc5233071427cf622aaad7abde9e19).
Original issue's description:
> Revert some other possible suspects of a 0.43% size increase of setup.exe: https://build.chromium.org/p/chromium/builders/Win/builds/31562
>
> Revert "Add granular base::File tracing."
>
> This reverts commit a6e05c977096a03774e5406d63ad80c0166f9adc.
>
> Revert "Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider"
>
> This reverts commit bce10d97d6fc5233071427cf622aaad7abde9e19.
>
> Revert "Avoid unnecessary memory allocations at PlatformThread::SetName()"
>
> This reverts commit 4839a142bf95776323647c82ca9dc0725f7c4f15.
>
> TBR=tdresser@chromium.org
> BUG=none
> TEST=green sizes
>
> Committed: https://chromium.googlesource.com/chromium/src/+/c41830d6f55f85e2f5c8841db4b6ed81239b671d
TBR=tdresser@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none
Review URL: https://codereview.chromium.org/1123833003
Cr-Commit-Position: refs/heads/master@{#328207}
Diffstat (limited to 'remoting/signaling')
-rw-r--r-- | remoting/signaling/xmpp_signal_strategy_unittest.cc | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/remoting/signaling/xmpp_signal_strategy_unittest.cc b/remoting/signaling/xmpp_signal_strategy_unittest.cc index b4c4a53..2193982 100644 --- a/remoting/signaling/xmpp_signal_strategy_unittest.cc +++ b/remoting/signaling/xmpp_signal_strategy_unittest.cc @@ -29,6 +29,14 @@ class XmppSocketDataProvider: public net::SocketDataProvider { void Reset() override {} + bool AllReadDataConsumed() const override { + return true; + } + + bool AllWriteDataConsumed() const override { + return true; + } + void ReceiveData(const std::string& text) { socket()->OnReadComplete( net::MockRead(net::ASYNC, text.data(), text.size())); |