diff options
| author | kelvinp@chromium.org <kelvinp@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-19 06:25:49 +0000 |
|---|---|---|
| committer | kelvinp@chromium.org <kelvinp@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-19 06:25:49 +0000 |
| commit | 90fafb792997c07c4f1914bdc9c3efd54bd7539a (patch) | |
| tree | 404940954cbc2bdd0c258fc6398ad62e4d6f8d70 /remoting/webapp | |
| parent | 203ef7611e934da86038a45f24a67f5c70d16d04 (diff) | |
| download | chromium_src-90fafb792997c07c4f1914bdc9c3efd54bd7539a.zip chromium_src-90fafb792997c07c4f1914bdc9c3efd54bd7539a.tar.gz chromium_src-90fafb792997c07c4f1914bdc9c3efd54bd7539a.tar.bz2 | |
Cause:
In the chromoting app, dialogues boxes are centered using flexbox. There is a recent regression in blink that causes flexbox to stop resizing when the content of its children get smaller. Bug 353216 is filed to track the issue.
https://code.google.com/p/chromium/issues/detail?id=353216
Fix:
There are simpler alternatives to horizontally center DOM elements without using complex layouts like flexbox. This change removes the flex box and sets margin to auto on the dialogs.
BUG=341976
Review URL: https://codereview.chromium.org/201293009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257873 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'remoting/webapp')
| -rw-r--r-- | remoting/webapp/html/dialog_auth.html | 2 | ||||
| -rw-r--r-- | remoting/webapp/html/template_main.html | 4 | ||||
| -rw-r--r-- | remoting/webapp/main.css | 2 |
3 files changed, 1 insertions, 7 deletions
diff --git a/remoting/webapp/html/dialog_auth.html b/remoting/webapp/html/dialog_auth.html index 92c3764..b57e5a5 100644 --- a/remoting/webapp/html/dialog_auth.html +++ b/remoting/webapp/html/dialog_auth.html @@ -8,7 +8,6 @@ found in the LICENSE file. <div class="dialog-screen"></div> <div class="dialog-container"> - <div class="box-spacer"></div> <div class="kd-modaldialog"> <h2 i18n-content="MODE_AUTHORIZE"></h2> <p id="auth-error-message" @@ -22,7 +21,6 @@ found in the LICENSE file. </button> </div> </div> - <div class="box-spacer"></div> </div> </div> <!-- auth-dialog --> diff --git a/remoting/webapp/html/template_main.html b/remoting/webapp/html/template_main.html index d7d455e..e690e3f 100644 --- a/remoting/webapp/html/template_main.html +++ b/remoting/webapp/html/template_main.html @@ -53,8 +53,6 @@ found in the LICENSE file. data-ui-mode="home.host home.client home.history home.confirm-host-delete home.host-install home.host-setup home.token-refresh-failed home.manage-pairings" hidden> - <div class="box-spacer"></div> - <meta-include src="webapp/html/dialog_token_refresh_failed.html"/> <meta-include src="webapp/html/dialog_host_setup.html"/> <meta-include src="webapp/html/dialog_host_install.html"/> @@ -78,8 +76,6 @@ found in the LICENSE file. <meta-include src="webapp/html/dialog_confirm_host_delete.html"/> <meta-include src="webapp/html/dialog_manage_pairings.html"/> - <div class="box-spacer"></div> - </div> <!-- dialog-container --> <div id="session-mode" diff --git a/remoting/webapp/main.css b/remoting/webapp/main.css index 7673498..7b50dbb 100644 --- a/remoting/webapp/main.css +++ b/remoting/webapp/main.css @@ -232,6 +232,7 @@ Component: Modal Dialog overflow: hidden; z-index: 100; opacity: 0.0; + margin: auto; -webkit-transform: scale(1.05); -webkit-transition: all 0.218s; } @@ -617,7 +618,6 @@ button { top: 200px; left: 0; width: 100%; - display: flex; } .dialog-screen { |