diff options
| author | sergeyu@chromium.org <sergeyu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-21 18:29:44 +0000 |
|---|---|---|
| committer | sergeyu@chromium.org <sergeyu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-21 18:29:44 +0000 |
| commit | 55ee0e510a15dc330b08851b943caca9996e5a83 (patch) | |
| tree | 0932a0f03384774eb9050beb3ef2d40b154e7ddd /remoting | |
| parent | 2f040f978353a97829763d3f97ca48725b1fa0aa (diff) | |
| download | chromium_src-55ee0e510a15dc330b08851b943caca9996e5a83.zip chromium_src-55ee0e510a15dc330b08851b943caca9996e5a83.tar.gz chromium_src-55ee0e510a15dc330b08851b943caca9996e5a83.tar.bz2 | |
Fix instability in SSL client/server sockets
When writing to a socket, net::StreamSocket::Write() may return
immediately, but it may not write the whole buffer passed to it.
In this case SSL sockets were not trying to call Write() again
to send rest of the data, until client tries to call Write()
next time. If client doesn't call Write the remaining data is
never sent to the transport socket.
remoting_unittests was flaky due to this bug.
BUG=88726
TEST=updated net_unittest to catch the bug, remoting_unittests is not flaky
Review URL: http://codereview.chromium.org/7399025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93445 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'remoting')
| -rw-r--r-- | remoting/protocol/jingle_session_unittest.cc | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/remoting/protocol/jingle_session_unittest.cc b/remoting/protocol/jingle_session_unittest.cc index 504176e..538ef05 100644 --- a/remoting/protocol/jingle_session_unittest.cc +++ b/remoting/protocol/jingle_session_unittest.cc @@ -641,8 +641,7 @@ TEST_F(JingleSessionTest, Connect) { } // Verify that data can be transmitted over the event channel. -// TODO(wez): See crbug.com/88726 -TEST_F(JingleSessionTest, FLAKY_TestControlChannel) { +TEST_F(JingleSessionTest, TestControlChannel) { CreateServerPair(); ASSERT_TRUE(InitiateConnection()); scoped_refptr<TCPChannelTester> tester( @@ -657,8 +656,7 @@ TEST_F(JingleSessionTest, FLAKY_TestControlChannel) { } // Verify that data can be transmitted over the video channel. -// TODO(wez): See crbug.com/88726 -TEST_F(JingleSessionTest, FLAKY_TestVideoChannel) { +TEST_F(JingleSessionTest, TestVideoChannel) { CreateServerPair(); ASSERT_TRUE(InitiateConnection()); scoped_refptr<TCPChannelTester> tester( @@ -673,8 +671,7 @@ TEST_F(JingleSessionTest, FLAKY_TestVideoChannel) { } // Verify that data can be transmitted over the event channel. -// TODO(wez): See crbug.com/88726 -TEST_F(JingleSessionTest, FLAKY_TestEventChannel) { +TEST_F(JingleSessionTest, TestEventChannel) { CreateServerPair(); ASSERT_TRUE(InitiateConnection()); scoped_refptr<TCPChannelTester> tester( |