diff options
| author | sdefresne@chromium.org <sdefresne@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-22 06:47:42 +0000 |
|---|---|---|
| committer | sdefresne@chromium.org <sdefresne@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-22 06:47:42 +0000 |
| commit | e24bcb45e2908fbb1da87b24b84a98d64d89c07c (patch) | |
| tree | 50bbece9284ff4cae0c1512bcc634c4dcc3de51c /rlz/lib | |
| parent | 5e5f7a21c7c7fda9b08e5a0f35e2576e30bb6f29 (diff) | |
| download | chromium_src-e24bcb45e2908fbb1da87b24b84a98d64d89c07c.zip chromium_src-e24bcb45e2908fbb1da87b24b84a98d64d89c07c.tar.gz chromium_src-e24bcb45e2908fbb1da87b24b84a98d64d89c07c.tar.bz2 | |
Use different Access Point on iOS for phone and tablet
Introduce an accessor for the value of the access point since it is no
longer a constant for the platform but may depends on conditions that
are only known at runtime (difference between phone and tablet on iOS).
Chrome on iOS will use the access point C9 and CD for tracking usage of
the omnibox on tablet and phone respectively.
BUG=375170
TBR=thakis
Review URL: https://codereview.chromium.org/292983003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272124 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'rlz/lib')
| -rw-r--r-- | rlz/lib/lib_values.cc | 7 | ||||
| -rw-r--r-- | rlz/lib/rlz_enums.h | 5 | ||||
| -rw-r--r-- | rlz/lib/rlz_lib.cc | 1 |
3 files changed, 5 insertions, 8 deletions
diff --git a/rlz/lib/lib_values.cc b/rlz/lib/lib_values.cc index 80e987a..397668b 100644 --- a/rlz/lib/lib_values.cc +++ b/rlz/lib/lib_values.cc @@ -98,11 +98,8 @@ const char* GetAccessPointName(AccessPoint point) { case CHROMEOS_OMNIBOX: return "CA"; case CHROMEOS_HOME_PAGE: return "CB"; case CHROMEOS_APP_LIST: return "CC"; - case CHROME_IOS_OMNIBOX: return "C9"; - // Returns an invalid access point value here as this value does not - // correspond to a defined access point, but need to be defined for - // code that iterates over all values of rlz_lib::AccessPoint. - case CHROME_IOS_RESERVED: return "__"; + case CHROME_IOS_OMNIBOX_TABLET: return "C9"; + case CHROME_IOS_OMNIBOX_MOBILE: return "CD"; case CHROME_APP_LIST: return "C7"; case CHROME_MAC_APP_LIST: return "C8"; case UNDEFINED_AP_Q: return "RQ"; diff --git a/rlz/lib/rlz_enums.h b/rlz/lib/rlz_enums.h index e50ac2f..e976f86 100644 --- a/rlz/lib/rlz_enums.h +++ b/rlz/lib/rlz_enums.h @@ -62,8 +62,9 @@ enum AccessPoint { CHROMEOS_HOME_PAGE, // ChromeOS searches through Google as home page. CHROMEOS_APP_LIST, // ChromeOS searches through the app launcher search box. - CHROME_IOS_OMNIBOX, // Chrome searches through the address bar omnibox (iOS). - CHROME_IOS_RESERVED, // Reserved for Chrome on iOS. + // Chrome searches through the address bar omnibox (iOS) on tablet or phone. + CHROME_IOS_OMNIBOX_TABLET, + CHROME_IOS_OMNIBOX_MOBILE, CHROME_APP_LIST, // Chrome searches through the app launcher search box. CHROME_MAC_APP_LIST, // Chrome searches through the app launcher search box diff --git a/rlz/lib/rlz_lib.cc b/rlz/lib/rlz_lib.cc index 95e3e09..39bec27 100644 --- a/rlz/lib/rlz_lib.cc +++ b/rlz/lib/rlz_lib.cc @@ -30,7 +30,6 @@ bool IsAccessPointSupported(rlz_lib::AccessPoint point) { switch (point) { case rlz_lib::NO_ACCESS_POINT: case rlz_lib::LAST_ACCESS_POINT: - case rlz_lib::CHROME_IOS_RESERVED: case rlz_lib::MOBILE_IDLE_SCREEN_BLACKBERRY: case rlz_lib::MOBILE_IDLE_SCREEN_WINMOB: |