diff options
| author | tapted <tapted@chromium.org> | 2016-01-13 22:26:37 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-01-14 06:28:13 +0000 |
| commit | 174fde33258d2128a25982fbaded0ffeefa2cd6d (patch) | |
| tree | 8e17fc028100fe110ed4f8356c89b35e3d393b5f /sandbox/win | |
| parent | 5b81d65c7382b3b855cbc5bd26a15cc68ef4c5e5 (diff) | |
| download | chromium_src-174fde33258d2128a25982fbaded0ffeefa2cd6d.zip chromium_src-174fde33258d2128a25982fbaded0ffeefa2cd6d.tar.gz chromium_src-174fde33258d2128a25982fbaded0ffeefa2cd6d.tar.bz2 | |
Move bit_cast from base/macros.h to its own header
There isn't much that uses bit_cast. bit_cast requires memcpy which
requires <string.h>
On Mac, <string.h> includes AvailabilityInternal.h which is half a
megabyte and defines dozens of macros. Providing <string.h> in
base/macros.h also tempts IWYU violations. Try to avoid it.
Add base/bit_cast.h and include it from the 17 files that need it. Then
remove the <string.h> #include from base/macros.h and IWYU.
BUG=395001
Review URL: https://codereview.chromium.org/399313006
Cr-Commit-Position: refs/heads/master@{#369348}
Diffstat (limited to 'sandbox/win')
| -rw-r--r-- | sandbox/win/src/Wow64.cc | 1 | ||||
| -rw-r--r-- | sandbox/win/src/service_resolver_32.cc | 1 | ||||
| -rw-r--r-- | sandbox/win/src/service_resolver_unittest.cc | 1 | ||||
| -rw-r--r-- | sandbox/win/wow_helper/service64_resolver.cc | 1 |
4 files changed, 4 insertions, 0 deletions
diff --git a/sandbox/win/src/Wow64.cc b/sandbox/win/src/Wow64.cc index d07d72f..c5984d6 100644 --- a/sandbox/win/src/Wow64.cc +++ b/sandbox/win/src/Wow64.cc @@ -8,6 +8,7 @@ #include <sstream> +#include "base/bit_cast.h" #include "base/logging.h" #include "base/memory/scoped_ptr.h" #include "base/win/scoped_process_information.h" diff --git a/sandbox/win/src/service_resolver_32.cc b/sandbox/win/src/service_resolver_32.cc index 4fc96d3..f809227 100644 --- a/sandbox/win/src/service_resolver_32.cc +++ b/sandbox/win/src/service_resolver_32.cc @@ -6,6 +6,7 @@ #include <stddef.h> +#include "base/bit_cast.h" #include "base/memory/scoped_ptr.h" #include "sandbox/win/src/win_utils.h" diff --git a/sandbox/win/src/service_resolver_unittest.cc b/sandbox/win/src/service_resolver_unittest.cc index 421b814..25d0875 100644 --- a/sandbox/win/src/service_resolver_unittest.cc +++ b/sandbox/win/src/service_resolver_unittest.cc @@ -6,6 +6,7 @@ #include <stddef.h> +#include "base/bit_cast.h" #include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "base/win/windows_version.h" diff --git a/sandbox/win/wow_helper/service64_resolver.cc b/sandbox/win/wow_helper/service64_resolver.cc index b5b67cc..0424d9f 100644 --- a/sandbox/win/wow_helper/service64_resolver.cc +++ b/sandbox/win/wow_helper/service64_resolver.cc @@ -7,6 +7,7 @@ #include <limits.h> #include <stddef.h> +#include "base/bit_cast.h" #include "base/memory/scoped_ptr.h" #include "sandbox/win/wow_helper/target_code.h" |