diff options
| author | shrikant <shrikant@chromium.org> | 2015-03-24 17:29:46 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-03-25 00:30:25 +0000 |
| commit | 3b26c1d230289b35f6c77d6aabb8464b15680ad7 (patch) | |
| tree | 272cb556073d27aa767671c2d1679b9d76193c4c /sandbox | |
| parent | 8185a19dabb74722ada9cb5bb4ba820a6053a522 (diff) | |
| download | chromium_src-3b26c1d230289b35f6c77d6aabb8464b15680ad7.zip chromium_src-3b26c1d230289b35f6c77d6aabb8464b15680ad7.tar.gz chromium_src-3b26c1d230289b35f6c77d6aabb8464b15680ad7.tar.bz2 | |
Adding one more error code to convey process creation/spawn target error to the caller BrokerServices.
The code to use this error code will be in follow-up CL. This will be useful to differentiate UMA for launch errors.
R=rvargas@chromium.org,cpu@chromium.org,jschuh@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1000863006
Cr-Commit-Position: refs/heads/master@{#322104}
Diffstat (limited to 'sandbox')
| -rw-r--r-- | sandbox/win/src/broker_services.cc | 6 | ||||
| -rw-r--r-- | sandbox/win/src/sandbox_types.h | 2 |
2 files changed, 6 insertions, 2 deletions
diff --git a/sandbox/win/src/broker_services.cc b/sandbox/win/src/broker_services.cc index d88e5eb..f23d431 100644 --- a/sandbox/win/src/broker_services.cc +++ b/sandbox/win/src/broker_services.cc @@ -487,8 +487,10 @@ ResultCode BrokerServicesBase::SpawnTarget(const wchar_t* exe_path, DWORD win_result = target->Create(exe_path, command_line, inherit_handles, policy_base->GetLowBoxSid() ? true : false, startup_info, &process_info); - if (ERROR_SUCCESS != win_result) - return SpawnCleanup(target, win_result); + if (ERROR_SUCCESS != win_result) { + SpawnCleanup(target, win_result); + return SBOX_ERROR_CREATE_PROCESS; + } // Now the policy is the owner of the target. if (!policy_base->AddTarget(target)) { diff --git a/sandbox/win/src/sandbox_types.h b/sandbox/win/src/sandbox_types.h index 22840ce..3e531be 100644 --- a/sandbox/win/src/sandbox_types.h +++ b/sandbox/win/src/sandbox_types.h @@ -45,6 +45,8 @@ enum ResultCode { SBOX_ERROR_CANNOT_INIT_APPCONTAINER = 16, // Initializing or updating ProcThreadAttributes failed. SBOX_ERROR_PROC_THREAD_ATTRIBUTES = 17, + // Error in creating process. + SBOX_ERROR_CREATE_PROCESS = 18, // Placeholder for last item of the enum. SBOX_ERROR_LAST }; |