diff options
| author | timurrrr@chromium.org <timurrrr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-04 08:13:13 +0000 |
|---|---|---|
| committer | timurrrr@chromium.org <timurrrr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-04 08:13:13 +0000 |
| commit | 22edb9c260dd8b1322bc40f0f4053a24c8b275c7 (patch) | |
| tree | 49d77c59cbd9ff2f50a9c66838d2429a505cb89f /skia/tools/filter_fuzz_stub | |
| parent | 8edc52cb4737bebd5f95b64ccd3d9c90354f55bd (diff) | |
| download | chromium_src-22edb9c260dd8b1322bc40f0f4053a24c8b275c7.zip chromium_src-22edb9c260dd8b1322bc40f0f4053a24c8b275c7.tar.gz chromium_src-22edb9c260dd8b1322bc40f0f4053a24c8b275c7.tar.bz2 | |
Revert 254567 "don't create SkDevice directly, use SkBitmap or (..."
Valgrind has detected a few uninitialized memory reads after this change
BUG=348905
> don't create SkDevice directly, use SkBitmap or (better) SkCanvas::NewRaster factory
>
> BUG=skia:2239
> TBR=scherkus@chromium.org
>
> Review URL: https://codereview.chromium.org/184743002
TBR=reed@google.com
Review URL: https://codereview.chromium.org/183003011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254714 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'skia/tools/filter_fuzz_stub')
| -rw-r--r-- | skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc b/skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc index 2d37a2d..1cb4d7f 100644 --- a/skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc +++ b/skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc @@ -4,6 +4,7 @@ #include "base/file_util.h" #include "base/logging.h" +#include "third_party/skia/include/core/SkBitmapDevice.h" #include "third_party/skia/include/core/SkCanvas.h" #include "third_party/skia/include/core/SkFlattenableSerialization.h" #include "third_party/skia/include/core/SkImageFilter.h" @@ -73,8 +74,10 @@ int main(int argc, char** argv) { int ret = 0; SkBitmap bitmap; - bitmap.allocN32Pixels(BitmapSize, BitmapSize); - SkCanvas canvas(bitmap); + bitmap.setConfig(SkBitmap::kARGB_8888_Config, BitmapSize, BitmapSize); + bitmap.allocPixels(); + SkBitmapDevice device(bitmap); + SkCanvas canvas(&device); canvas.clear(0x00000000); for (int i = 1; i < argc; i++) |