diff options
| author | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-30 00:57:17 +0000 |
|---|---|---|
| committer | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-30 00:57:17 +0000 |
| commit | f7fe6a41c7c72b7927d65fbcaa67d61f03867887 (patch) | |
| tree | 7e15ec2a6645c119a4d0215c3421b4a74a193b5c /sql/connection.cc | |
| parent | 74c437b31a2d551849f8a64c2f09a68629dfaf99 (diff) | |
| download | chromium_src-f7fe6a41c7c72b7927d65fbcaa67d61f03867887.zip chromium_src-f7fe6a41c7c72b7927d65fbcaa67d61f03867887.tar.gz chromium_src-f7fe6a41c7c72b7927d65fbcaa67d61f03867887.tar.bz2 | |
Revert 197147 "Deeper histogram for SQLITE_IOERR."
> Deeper histogram for SQLITE_IOERR.
>
> Sqlite.Error records the basic SQLite error codes. Most of the
> extended codes are under SQLITE_IOERR, add a new histogram to record
> those.
>
> BUG=none
>
> Review URL: https://chromiumcodereview.appspot.com/14439007
TBR=shess@chromium.org
Review URL: https://codereview.chromium.org/14555006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197196 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'sql/connection.cc')
| -rw-r--r-- | sql/connection.cc | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/sql/connection.cc b/sql/connection.cc index 29708e4..5f6b590 100644 --- a/sql/connection.cc +++ b/sql/connection.cc @@ -714,15 +714,6 @@ int Connection::OnSqliteError(int err, sql::Statement *stmt) { static size_t kSqliteErrorMax = 50; UMA_HISTOGRAM_ENUMERATION("Sqlite.Error", base_err, kSqliteErrorMax); - if (base_err == SQLITE_IOERR) { - // TODO(shess): Consider folding the IOERR range into the main - // histogram directly. Perhaps 30..49? The downside risk would - // be that SQLite core adds a bunch of codes and this becomes a - // complicated mapping. - static size_t kSqliteIOErrorMax = 20; - UMA_HISTOGRAM_ENUMERATION("Sqlite.Error.IOERR", err>>8, kSqliteIOErrorMax); - } - if (!error_histogram_name_.empty()) { // TODO(shess): The histogram macros create a bit of static // storage for caching the histogram object. Since SQLite is |