diff options
| author | brettw <brettw@chromium.org> | 2015-02-19 15:17:04 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-02-19 23:18:14 +0000 |
| commit | d1c719acf7db459016f425eb8018ec4208511578 (patch) | |
| tree | f5604ba0055245c0133cd5747e8a70de99b917f7 /sql | |
| parent | 9ff250e0023b2f87e0fddd7eadbef7be3ecc3882 (diff) | |
| download | chromium_src-d1c719acf7db459016f425eb8018ec4208511578.zip chromium_src-d1c719acf7db459016f425eb8018ec4208511578.tar.gz chromium_src-d1c719acf7db459016f425eb8018ec4208511578.tar.bz2 | |
Update existing uses of /wd4267 to use the GN config
This is the size_t to integer conversion warning. Using the config prevents flag duplication and is clearer to read.
Minor updates to Win64 build, including some fixes for size_t to int conversions.
Review URL: https://codereview.chromium.org/929793006
Cr-Commit-Position: refs/heads/master@{#317162}
Diffstat (limited to 'sql')
| -rw-r--r-- | sql/BUILD.gn | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/sql/BUILD.gn b/sql/BUILD.gn index 7c4d3f0..8b75d80 100644 --- a/sql/BUILD.gn +++ b/sql/BUILD.gn @@ -21,11 +21,10 @@ component("sql") { "transaction.h", ] - defines = [ "SQL_IMPLEMENTATION" ] + # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. + configs += [ "//build/config/compiler:no_size_t_to_int_warning" ] - if (is_win) { - cflags = [ "/wd4267" ] # size_t to int. - } + defines = [ "SQL_IMPLEMENTATION" ] deps = [ "//base", @@ -68,9 +67,8 @@ test("sql_unittests") { "transaction_unittest.cc", ] - if (is_win) { - cflags = [ "/wd4267" ] # size_t -> int - } + # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. + configs += [ "//build/config/compiler:no_size_t_to_int_warning" ] deps = [ ":sql", |