summaryrefslogtreecommitdiffstats
path: root/styleguide
diff options
context:
space:
mode:
authordcheng <dcheng@chromium.org>2014-09-26 16:25:04 -0700
committerCommit bot <commit-bot@chromium.org>2014-09-26 23:25:21 +0000
commit0e418df26c45af6a62d2c3e7b05f4496058d5e86 (patch)
tree597820f7ce54892e49e429fa38ae6adc28ad2ed4 /styleguide
parent29d1208bfd30add739982738a6f11f7b0dbcfcd0 (diff)
downloadchromium_src-0e418df26c45af6a62d2c3e7b05f4496058d5e86.zip
chromium_src-0e418df26c45af6a62d2c3e7b05f4496058d5e86.tar.gz
chromium_src-0e418df26c45af6a62d2c3e7b05f4496058d5e86.tar.bz2
Move explicit conversion operators to the banned section.
Unfortunately, they are broken as implemented in MSVS 2013. Review URL: https://codereview.chromium.org/609963004 Cr-Commit-Position: refs/heads/master@{#297066}
Diffstat (limited to 'styleguide')
-rw-r--r--styleguide/c++/c++11.html22
1 files changed, 11 insertions, 11 deletions
diff --git a/styleguide/c++/c++11.html b/styleguide/c++/c++11.html
index 80e99d8..8cfc013 100644
--- a/styleguide/c++/c++11.html
+++ b/styleguide/c++/c++11.html
@@ -185,12 +185,22 @@ codebase.
<td><code>constexpr</code></td>
<td>Compile-time constant expressions</td>
<td>TODO: documentation link</td>
-<td>Doesn't work in MSVS2013. Reevalute once it does.<a
+<td>Doesn't work in MSVS2013. Reevalute once it does. <a
href="https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#constexpr">Google
Style Guide on <code>constexpr</code></a></td>
</tr>
<tr>
+<td>Explicit Conversion Operators</td>
+<td><code>explicit operator <i>type</i>() {
+<br />&nbsp;&nbsp;// code<br /> }</code></td>
+<td>Allows conversion operators that cannot be implicitly invoked</td>
+<td><a href="http://en.cppreference.com/w/cpp/language/explicit">
+explicit specifier</a></td>
+<td><a href="https://connect.microsoft.com/VisualStudio/feedback/details/811334/bug-in-vs-2013-support-for-explicit-conversion-operators">Doesn't work in MSVS2013</a>. Reevaluate once it does. <a href="https://groups.google.com/a/chromium.org/d/msg/chromium-dev/zGF1SrQ-1HQ/BAiC12vwPeEJ">Discussion thread</a></td>
+</tr>
+
+<tr>
<td>Function Local Variable</td>
<td><code>__func__</code></td>
<td>Provides a local variable of the name of the enclosing
@@ -346,16 +356,6 @@ std::exception</a></td>
</tr>
<tr>
-<td>Explicit Conversion Operators</td>
-<td><code>explicit operator <i>type</i>() {
-<br />&nbsp;&nbsp;// code<br /> }</code></td>
-<td>Allows conversion operators that cannot be implicitly invoked</td>
-<td><a href="http://en.cppreference.com/w/cpp/language/explicit">
-explicit specifier</a></td>
-<td></td>
-</tr>
-
-<tr>
<td>Function Suppression</td>
<td><code><i>Function</i>(<i>arguments</i>) = delete;</code></td>
<td>Suppresses the implementation of a function, especially a